Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/assets/player/shared/peertube/peertube-plugin.ts

Summary

Maintainability
F
3 days
Test Coverage

File peertube-plugin.ts has 469 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { timeToInt } from '@peertube/peertube-core-utils'
import { VideoView, VideoViewEvent } from '@peertube/peertube-models'
import { logger } from '@root-helpers/logger'
import { isIOS, isMobile, isSafari } from '@root-helpers/web-browser'
import debug from 'debug'
Severity: Minor
Found in client/src/assets/player/shared/peertube/peertube-plugin.ts - About 7 hrs to fix

    PeerTubePlugin has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class PeerTubePlugin extends Plugin {
  declare private readonly videoViewUrl: () => string
  declare private readonly authorizationHeader: () => string
  declare private readonly initialInactivityTimeout: number
    Severity: Minor
    Found in client/src/assets/player/shared/peertube/peertube-plugin.ts - About 3 hrs to fix

      Function constructor has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor (player: videojs.Player, private readonly options: PeerTubePluginOptions) {
    super(player)

    this.menuOpened = false
    this.mouseInControlBar = false
      Severity: Major
      Found in client/src/assets/player/shared/peertube/peertube-plugin.ts - About 2 hrs to fix

        Function runUserViewing has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private runUserViewing () {
    const startTime = timeToInt(this.options.startTime())

    let lastCurrentTime = startTime
    let lastViewEvent: VideoViewEvent
        Severity: Minor
        Found in client/src/assets/player/shared/peertube/peertube-plugin.ts - About 1 hr to fix

          Function runUserViewing has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            private runUserViewing () {
    const startTime = timeToInt(this.options.startTime())

    let lastCurrentTime = startTime
    let lastViewEvent: VideoViewEvent
          Severity: Minor
          Found in client/src/assets/player/shared/peertube/peertube-plugin.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function displayFatalError has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            displayFatalError () {
    // Already displayed an error
    if (this.errorModal) return

    debugLogger('Display fatal error')
          Severity: Minor
          Found in client/src/assets/player/shared/peertube/peertube-plugin.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (this.options.isLive()) {
      this.getPlaybackRateButton().hide()

      this.player.controlBar.getChild('progressControl').hide()
      this.player.controlBar.getChild('currentTimeDisplay').hide()
            Severity: Major
            Found in client/src/assets/player/shared/peertube/peertube-plugin.ts and 1 other location - About 5 hrs to fix
            client/src/assets/player/shared/peertube/peertube-plugin.ts on lines 550..559

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 150.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else {
      this.getPlaybackRateButton().show()

      this.player.controlBar.getChild('progressControl').show()
      this.player.controlBar.getChild('currentTimeDisplay').show()
            Severity: Major
            Found in client/src/assets/player/shared/peertube/peertube-plugin.ts and 1 other location - About 5 hrs to fix
            client/src/assets/player/shared/peertube/peertube-plugin.ts on lines 541..550

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 150.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              private getPlaybackRateButton () {
    const settingsButton = this.player.controlBar.getDescendant([ 'settingsButton' ]) as SettingsButton

    return settingsButton.menu.getChild('playbackRateMenuButton')
  }
            Severity: Minor
            Found in client/src/assets/player/shared/peertube/peertube-plugin.ts and 1 other location - About 45 mins to fix
            client/src/assets/player/shared/p2p-media-loader/p2p-media-loader-plugin.ts on lines 279..283

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status