Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/standalone/videos/shared/player-options-builder.ts

Summary

Maintainability
D
2 days
Test Coverage

File player-options-builder.ts has 365 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { peertubeTranslate } from '@peertube/peertube-core-utils'
import {
  HTMLServerConfig,
  LiveVideo,
  Storyboard,
Severity: Minor
Found in client/src/standalone/videos/shared/player-options-builder.ts - About 4 hrs to fix

    PlayerOptionsBuilder has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class PlayerOptionsBuilder {
  private autoplay: boolean

  private controls: boolean
  private controlBar: boolean
    Severity: Minor
    Found in client/src/standalone/videos/shared/player-options-builder.ts - About 3 hrs to fix

      Function getPlayerLoadOptions has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async getPlayerLoadOptions (options: {
    video: VideoDetails
    captionsResponse: Response

    storyboardsResponse: Response
      Severity: Major
      Found in client/src/standalone/videos/shared/player-options-builder.ts - About 2 hrs to fix

        Function buildPlaylistOptions has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private buildPlaylistOptions (options?: {
    playlistTracker: PlaylistTracker
    playNext: () => any
    playPrevious: () => any
    onVideoUpdate: (uuid: string) => any
        Severity: Minor
        Found in client/src/standalone/videos/shared/player-options-builder.ts - About 1 hr to fix

          Function loadVideoParams has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            loadVideoParams (config: HTMLServerConfig, video: VideoDetails) {
    try {
      const params = new URL(window.location.toString()).searchParams

      this.autoplay = getParamToggle(params, 'autoplay', false)
          Severity: Minor
          Found in client/src/standalone/videos/shared/player-options-builder.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getPlayerConstructorOptions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            getPlayerConstructorOptions (options: {
    serverConfig: HTMLServerConfig
    authorizationHeader: () => string
  }): PeerTubePlayerContructorOptions {
    const { serverConfig, authorizationHeader } = options
          Severity: Minor
          Found in client/src/standalone/videos/shared/player-options-builder.ts - About 1 hr to fix

            Function buildDockOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              private buildDockOptions (videoInfo: VideoDetails) {
    if (!this.hasControls()) return undefined

    const title = this.hasTitle()
      ? videoInfo.name
            Severity: Minor
            Found in client/src/standalone/videos/shared/player-options-builder.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                return {
      playlistUrl: hlsPlaylist.playlistUrl,
      segmentsSha256Url: hlsPlaylist.segmentsSha256Url,
      redundancyBaseUrls: hlsPlaylist.redundancies.map(r => r.baseUrl),
      trackerAnnounce: video.trackerUrls,
            Severity: Major
            Found in client/src/standalone/videos/shared/player-options-builder.ts and 1 other location - About 1 hr to fix
            client/src/app/+videos/+video-watch/video-watch.component.ts on lines 757..763

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                playlist?: {
      playlistTracker: PlaylistTracker
      playNext: () => any
      playPrevious: () => any
      onVideoUpdate: (uuid: string) => any
            Severity: Major
            Found in client/src/standalone/videos/shared/player-options-builder.ts and 1 other location - About 1 hr to fix
            client/src/standalone/videos/shared/player-options-builder.ts on lines 351..356

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              private buildPlaylistOptions (options?: {
    playlistTracker: PlaylistTracker
    playNext: () => any
    playPrevious: () => any
    onVideoUpdate: (uuid: string) => any
            Severity: Major
            Found in client/src/standalone/videos/shared/player-options-builder.ts and 1 other location - About 1 hr to fix
            client/src/standalone/videos/shared/player-options-builder.ts on lines 240..245

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status