Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
packages/ffmpeg/src/ffmpeg-live.ts

Summary

Maintainability
C
1 day
Test Coverage

Function getLiveTranscodingCommand has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  async getLiveTranscodingCommand (options: LiveTranscodingOptions) {
    this.commandWrapper.debugLog('Building live transcoding command', options)

    const {
      inputUrl,
Severity: Minor
Found in packages/ffmpeg/src/ffmpeg-live.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLiveTranscodingCommand has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async getLiveTranscodingCommand (options: LiveTranscodingOptions) {
    this.commandWrapper.debugLog('Building live transcoding command', options)

    const {
      inputUrl,
Severity: Major
Found in packages/ffmpeg/src/ffmpeg-live.ts - About 2 hrs to fix

    Function buildTranscodingStream has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private async buildTranscodingStream (
    options: Pick<LiveTranscodingOptions, 'inputUrl' | 'bitrate' | 'ratio' | 'probe' | 'hasAudio' | 'splitAudioAndVideo'> & {
      command: FfmpegCommand
      resolution: number
      fps: number
    Severity: Major
    Found in packages/ffmpeg/src/ffmpeg-live.ts - About 2 hrs to fix

      Function buildTranscodingStream has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        private async buildTranscodingStream (
    options: Pick<LiveTranscodingOptions, 'inputUrl' | 'bitrate' | 'ratio' | 'probe' | 'hasAudio' | 'splitAudioAndVideo'> & {
      command: FfmpegCommand
      resolution: number
      fps: number
      Severity: Minor
      Found in packages/ffmpeg/src/ffmpeg-live.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                  if (!hasAudio || (splitAudioAndVideo && alreadyProcessedAudio)) continue
      Severity: Major
      Found in packages/ffmpeg/src/ffmpeg-live.ts - About 45 mins to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            const { inputUrl, bitrate, ratio, probe, splitAudioAndVideo, command, resolution, fps, streamNum, streamType, hasAudio } = options
        Severity: Major
        Found in packages/ffmpeg/src/ffmpeg-live.ts and 3 other locations - About 1 hr to fix
        client/src/app/shared/shared-main/video/video.service.ts on lines 540..552
        packages/server-commands/src/shared/abstract-command.ts on lines 184..184
        server/core/lib/transcoding/hls-transcoding.ts on lines 161..173

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  const result = await this.buildTranscodingStream({ ...options, command, resolution, fps, streamNum: i, streamType })
        Severity: Minor
        Found in packages/ffmpeg/src/ffmpeg-live.ts and 1 other location - About 35 mins to fix
        packages/server-commands/src/shared/abstract-command.ts on lines 275..283

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status