Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
packages/server-commands/src/server/jobs.ts

Summary

Maintainability
C
1 day
Test Coverage

Function waitJobs has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

async function waitJobs (
  serversArg: PeerTubeServer[] | PeerTubeServer,
  options: {
    skipDelayed?: boolean // default false
    runnerJobs?: boolean // default false
Severity: Minor
Found in packages/server-commands/src/server/jobs.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function waitJobs has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function waitJobs (
  serversArg: PeerTubeServer[] | PeerTubeServer,
  options: {
    skipDelayed?: boolean // default false
    runnerJobs?: boolean // default false
Severity: Major
Found in packages/server-commands/src/server/jobs.ts - About 2 hrs to fix

    Function tasksBuilder has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function tasksBuilder () {
    const tasks: Promise<any>[] = []

    // Check if each server has pending request
    for (const server of servers) {
    Severity: Minor
    Found in packages/server-commands/src/server/jobs.ts - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                      if (process.env.DEBUG) {
                  console.log(`${new Date().toISOString()}`, job)
                }
      Severity: Major
      Found in packages/server-commands/src/server/jobs.ts - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (jobs.length !== 0) {
              pendingRequests = true

              if (process.env.DEBUG) {
                console.log(`${new Date().toISOString()}`, jobs)
        Severity: Major
        Found in packages/server-commands/src/server/jobs.ts and 1 other location - About 1 hr to fix
        packages/server-commands/src/server/jobs.ts on lines 72..78

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      if (job.state.id !== RunnerJobState.COMPLETED) {
                pendingRequests = true

                if (process.env.DEBUG) {
                  console.log(`${new Date().toISOString()}`, job)
        Severity: Major
        Found in packages/server-commands/src/server/jobs.ts and 1 other location - About 1 hr to fix
        packages/server-commands/src/server/jobs.ts on lines 44..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status