Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
packages/types-generator/generate-package.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function run has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function run () {
  const typesPath = currentDir(import.meta.url)
  const typesDistTMPPath = join(typesPath, 'dist-tmp')

  await remove(typesDistTMPPath)
Severity: Major
Found in packages/types-generator/generate-package.ts - About 2 hrs to fix

    Identical blocks of code found in 15 locations. Consider refactoring.
    Open

    run()
  .then(() => process.exit(0))
  .catch(err => {
    console.error(err)
    process.exit(-1)
    Severity: Major
    Found in packages/types-generator/generate-package.ts and 14 other locations - About 1 hr to fix
    scripts/generate-code-contributors.ts on lines 3..8
    server/scripts/create-generate-storyboard-job.ts on lines 22..27
    server/scripts/create-import-video-file-job.ts on lines 21..26
    server/scripts/create-move-video-storage-job.ts on lines 36..41
    server/scripts/house-keeping.ts on lines 20..25
    server/scripts/migrations/peertube-4.0.ts on lines 17..23
    server/scripts/migrations/peertube-4.2.ts on lines 17..22
    server/scripts/migrations/peertube-5.0.ts on lines 11..16
    server/scripts/migrations/peertube-6.3.ts on lines 12..17
    server/scripts/plugin/install.ts on lines 24..29
    server/scripts/plugin/uninstall.ts on lines 16..21
    server/scripts/prune-storage.ts on lines 24..29
    server/scripts/update-host.ts on lines 25..30
    server/scripts/update-object-storage-url.ts on lines 17..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (Object.keys(result.invalidDirs).length !== 0) {
    console.error('Invalid directories detected.', { invalidDirs: result.invalidDirs })
    process.exit(-1)
  }
    Severity: Major
    Found in packages/types-generator/generate-package.ts and 1 other location - About 1 hr to fix
    packages/types-generator/generate-package.ts on lines 77..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (Object.keys(result.invalidFiles).length !== 0) {
    console.error('Invalid files detected.', { invalidFiles: result.invalidFiles })
    process.exit(-1)
  }
    Severity: Major
    Found in packages/types-generator/generate-package.ts and 1 other location - About 1 hr to fix
    packages/types-generator/generate-package.ts on lines 72..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status