Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/controllers/api/runners/jobs.ts

Summary

Maintainability
B
5 hrs
Test Coverage

File jobs.ts has 323 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  AbortRunnerJobBody,
  AcceptRunnerJobResult,
  ErrorRunnerJobBody,
  HttpStatusCode,
Severity: Minor
Found in server/core/controllers/api/runners/jobs.ts - About 3 hrs to fix

    Function acceptRunnerJob has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function acceptRunnerJob (req: express.Request, res: express.Response) {
  const runner = res.locals.runner
  const runnerJob = res.locals.runnerJob

  const newRunnerJob = await retryTransactionWrapper(() => {
    Severity: Minor
    Found in server/core/controllers/api/runners/jobs.ts - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        const resultList = await RunnerJobModel.listForApi({
    start: query.start,
    count: query.count,
    sort: query.sort,
    search: query.search,
      Severity: Minor
      Found in server/core/controllers/api/runners/jobs.ts and 2 other locations - About 35 mins to fix
      client/src/standalone/videos/embed-api.ts on lines 190..196
      server/core/lib/video-channel.ts on lines 16..22

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status