Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/auth/external-auth.ts

Summary

Maintainability
C
1 day
Test Coverage

Function getBypassFromPasswordGrant has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function getBypassFromPasswordGrant (username: string, password: string): Promise<BypassLogin> {
  const plugins = PluginManager.Instance.getIdAndPassAuths()
  const pluginAuths: { npmName?: string, registerAuthOptions: RegisterServerAuthPassOptions }[] = []

  for (const plugin of plugins) {
Severity: Minor
Found in server/core/lib/auth/external-auth.ts - About 2 hrs to fix

    Function onExternalUserAuthenticated has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function onExternalUserAuthenticated (options: {
  npmName: string
  authName: string
  authResult: RegisterServerExternalAuthenticatedResult
}) {
    Severity: Minor
    Found in server/core/lib/auth/external-auth.ts - About 1 hr to fix

      Function getBypassFromPasswordGrant has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      async function getBypassFromPasswordGrant (username: string, password: string): Promise<BypassLogin> {
  const plugins = PluginManager.Instance.getIdAndPassAuths()
  const pluginAuths: { npmName?: string, registerAuthOptions: RegisterServerAuthPassOptions }[] = []

  for (const plugin of plugins) {
      Severity: Minor
      Found in server/core/lib/auth/external-auth.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isAuthResultValid has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function isAuthResultValid (npmName: string, authName: string, result: RegisterServerAuthenticatedResult) {
  const returnError = (field: string) => {
    logger.error('Auth method %s of plugin %s did not provide a valid %s.', authName, npmName, field, { [field]: result[field] })
    return false
  }
      Severity: Minor
      Found in server/core/lib/auth/external-auth.ts - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

        if (result.adminFlags && !isUserAdminFlagsValid(result.adminFlags)) return returnError('adminFlags')
      Severity: Major
      Found in server/core/lib/auth/external-auth.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          if (result.videoQuota && !isUserVideoQuotaValid(result.videoQuota + '')) return returnError('videoQuota')
        Severity: Major
        Found in server/core/lib/auth/external-auth.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return false
          Severity: Major
          Found in server/core/lib/auth/external-auth.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              if (result.videoQuotaDaily && !isUserVideoQuotaDailyValid(result.videoQuotaDaily + '')) return returnError('videoQuotaDaily')
            Severity: Major
            Found in server/core/lib/auth/external-auth.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return true
              Severity: Major
              Found in server/core/lib/auth/external-auth.ts - About 30 mins to fix

                Function onExternalUserAuthenticated has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                async function onExternalUserAuthenticated (options: {
  npmName: string
  authName: string
  authResult: RegisterServerExternalAuthenticatedResult
}) {
                Severity: Minor
                Found in server/core/lib/auth/external-auth.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status