Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/hls.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function updateMasterHLSPlaylist has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function updateMasterHLSPlaylist (video: MVideo, playlistArg: MStreamingPlaylist): Promise<MStreamingPlaylistFilesVideo> {
  return playlistFilesQueue.add(async () => {
    const playlist = await VideoStreamingPlaylistModel.loadWithVideoAndFiles(playlistArg.id)

    const extMedia: string[] = []
Severity: Major
Found in server/core/lib/hls.ts - About 2 hrs to fix

    Function downloadPlaylistSegments has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function downloadPlaylistSegments (playlistUrl: string, destinationDir: string, timeout: number, bodyKBLimit: number) {
  let timer
  let remainingBodyKBLimit = bodyKBLimit

  logger.info('Importing HLS playlist %s', playlistUrl)
    Severity: Minor
    Found in server/core/lib/hls.ts - About 1 hr to fix

      Function updateSha256VODSegments has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function updateSha256VODSegments (video: MVideo, playlistArg: MStreamingPlaylist): Promise<MStreamingPlaylistFilesVideo> {
  return playlistFilesQueue.add(async () => {
    const json: { [filename: string]: { [range: string]: string } } = {}

    const playlist = await VideoStreamingPlaylistModel.loadWithVideoAndFiles(playlistArg.id)
      Severity: Minor
      Found in server/core/lib/hls.ts - About 1 hr to fix

        Function downloadPlaylistSegments has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export function downloadPlaylistSegments (playlistUrl: string, destinationDir: string, timeout: number, bodyKBLimit: number) {
  let timer
  let remainingBodyKBLimit = bodyKBLimit

  logger.info('Importing HLS playlist %s', playlistUrl)
        Severity: Minor
        Found in server/core/lib/hls.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status