Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/job-queue/handlers/activitypub-cleaner.ts

Summary

Maintainability
C
1 day
Test Coverage

Function updateObjectIfNeeded has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function updateObjectIfNeeded <T> (options: {
  url: string
  bodyValidator: (body: any) => boolean
  updater: (url: string, newUrl: string) => Promise<T>
  deleter: (url: string) => Promise<T> }
Severity: Minor
Found in server/core/lib/job-queue/handlers/activitypub-cleaner.ts - About 1 hr to fix

    Function updateObjectIfNeeded has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    async function updateObjectIfNeeded <T> (options: {
  url: string
  bodyValidator: (body: any) => boolean
  updater: (url: string, newUrl: string) => Promise<T>
  deleter: (url: string) => Promise<T> }
    Severity: Minor
    Found in server/core/lib/job-queue/handlers/activitypub-cleaner.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function processActivityPubCleaner has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function processActivityPubCleaner (_job: Job) {
  logger.info('Processing ActivityPub cleaner.', lTags())

  {
    const rateUrls = await AccountVideoRateModel.listRemoteRateUrlsOfLocalVideos()
    Severity: Minor
    Found in server/core/lib/job-queue/handlers/activitypub-cleaner.ts - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

            return on404OrTombstone()
      Severity: Major
      Found in server/core/lib/job-queue/handlers/activitypub-cleaner.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return null
        Severity: Major
        Found in server/core/lib/job-queue/handlers/activitypub-cleaner.ts - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            {
    const commentUrls = await VideoCommentModel.listRemoteCommentUrlsOfLocalVideos()
    const { bodyValidator, deleter, updater } = commentOptionsFactory()

    await Bluebird.map(commentUrls, async commentUrl => {
          Severity: Major
          Found in server/core/lib/job-queue/handlers/activitypub-cleaner.ts and 1 other location - About 3 hrs to fix
          server/core/lib/job-queue/handlers/activitypub-cleaner.ts on lines 46..53

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            {
    const shareUrls = await VideoShareModel.listRemoteShareUrlsOfLocalVideos()
    const { bodyValidator, deleter, updater } = shareOptionsFactory()

    await Bluebird.map(shareUrls, async shareUrl => {
          Severity: Major
          Found in server/core/lib/job-queue/handlers/activitypub-cleaner.ts and 1 other location - About 3 hrs to fix
          server/core/lib/job-queue/handlers/activitypub-cleaner.ts on lines 55..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status