Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/job-queue/handlers/activitypub-follow.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function processActivityPubFollow has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

async function processActivityPubFollow (job: Job) {
  const payload = job.data as ActivitypubFollowPayload
  const host = payload.host

  const handle = host
Severity: Minor
Found in server/core/lib/job-queue/handlers/activitypub-follow.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processActivityPubFollow has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function processActivityPubFollow (job: Job) {
  const payload = job.data as ActivitypubFollowPayload
  const host = payload.host

  const handle = host
Severity: Minor
Found in server/core/lib/job-queue/handlers/activitypub-follow.ts - About 1 hr to fix

    Function follow has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    async function follow (fromActor: MActor, targetActor: MActorFull, isAutoFollow = false) {
  if (fromActor.id === targetActor.id) {
    throw new Error('Follower is the same as target actor.')
  }
    Severity: Minor
    Found in server/core/lib/job-queue/handlers/activitypub-follow.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status