Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/job-queue/handlers/video-import.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function processFile has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function processFile (downloader: () => Promise<string>, videoImport: MVideoImportDefault, options: ProcessFileOptions) {
  let tmpVideoPath: string
  let videoFile: MVideoFile

  try {
Severity: Major
Found in server/core/lib/job-queue/handlers/video-import.ts - About 3 hrs to fix

    File video-import.ts has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { buildAspectRatio } from '@peertube/peertube-core-utils'
import {
  ffprobePromise,
  getChaptersFromContainer, getVideoStreamDuration
} from '@peertube/peertube-ffmpeg'
    Severity: Minor
    Found in server/core/lib/job-queue/handlers/video-import.ts - About 2 hrs to fix

      Function processVideoImport has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      async function processVideoImport (job: Job): Promise<VideoImportPreventExceptionResult> {
  const payload = job.data as VideoImportPayload

  const videoImport = await getVideoImportOrDie(payload)
  if (videoImport.state === VideoImportState.CANCELLED) {
      Severity: Minor
      Found in server/core/lib/job-queue/handlers/video-import.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function afterImportSuccess has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function afterImportSuccess (options: {
  videoImport: MVideoImport
  video: MVideoFullLight
  videoFile: MVideoFile
  user: MUserId
      Severity: Minor
      Found in server/core/lib/job-queue/handlers/video-import.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status