Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/job-queue/handlers/video-live-ending.ts

Summary

Maintainability
C
1 day
Test Coverage

File video-live-ending.ts has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { ffprobePromise, getAudioStream, getVideoStreamDimensionsInfo, getVideoStreamFPS } from '@peertube/peertube-ffmpeg'
import { ThumbnailType, VideoFileStream, VideoLiveEndingPayload, VideoState } from '@peertube/peertube-models'
import { peertubeTruncate } from '@server/helpers/core-utils.js'
import { CONSTRAINTS_FIELDS } from '@server/initializers/constants.js'
import { getLocalVideoActivityPubUrl } from '@server/lib/activitypub/url.js'
Severity: Minor
Found in server/core/lib/job-queue/handlers/video-live-ending.ts - About 3 hrs to fix

    Function saveReplayToExternalVideo has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function saveReplayToExternalVideo (options: {
  liveVideo: MVideoThumbnail
  liveSession: MVideoLiveSession
  publishedAt: string
  replayDirectory: string
    Severity: Major
    Found in server/core/lib/job-queue/handlers/video-live-ending.ts - About 2 hrs to fix

      Function replaceLiveByReplay has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function replaceLiveByReplay (options: {
  video: MVideo
  liveSession: MVideoLiveSession
  live: MVideoLive
  permanentLive: boolean
      Severity: Minor
      Found in server/core/lib/job-queue/handlers/video-live-ending.ts - About 1 hr to fix

        Function processVideoLiveEnding has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        async function processVideoLiveEnding (job: Job) {
  const payload = job.data as VideoLiveEndingPayload

  logger.info('Processing video live ending for %s.', payload.videoId, { payload, ...lTags() })
        Severity: Minor
        Found in server/core/lib/job-queue/handlers/video-live-ending.ts - About 1 hr to fix

          Function copyOrRegenerateThumbnails has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function copyOrRegenerateThumbnails (options: {
  liveVideo: MVideoThumbnail
  replayVideo: MVideoWithFileThumbnail
}) {
  const { liveVideo, replayVideo } = options
          Severity: Minor
          Found in server/core/lib/job-queue/handlers/video-live-ending.ts - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

              return replaceLiveByReplay({
    video,
    liveSession,
    live,
    permanentLive,
            Severity: Major
            Found in server/core/lib/job-queue/handlers/video-live-ending.ts - About 30 mins to fix

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  logger.error(
      `Cannot copy/regenerate thumbnails of ended live ${liveVideo.uuid} to external video ${replayVideo.uuid}`,
      lTags(liveVideo.uuid, replayVideo.uuid)
    )
              Severity: Major
              Found in server/core/lib/job-queue/handlers/video-live-ending.ts and 4 other locations - About 35 mins to fix
              server/core/controllers/api/users/index.ts on lines 202..202
              server/core/controllers/api/users/index.ts on lines 216..216
              server/core/controllers/api/users/index.ts on lines 256..256
              server/core/controllers/api/users/index.ts on lines 292..292

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                logger.info(`Replacing live ${liveVideo.uuid} by replay ${replayDirectory}.`, { replayInAnotherDirectory, ...lTags(liveVideo.uuid) })
              Severity: Minor
              Found in server/core/lib/job-queue/handlers/video-live-ending.ts and 1 other location - About 35 mins to fix
              server/core/lib/video-captions.ts on lines 110..113

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status