Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/transcoding/web-transcoding.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function mergeAudioVideofile has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function mergeAudioVideofile (options: {
  video: MVideoFullLight
  resolution: number
  fps: number
  job: Job
Severity: Minor
Found in server/core/lib/transcoding/web-transcoding.ts - About 1 hr to fix

    Function onWebVideoFileTranscoding has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function onWebVideoFileTranscoding (options: {
  video: MVideoFullLight
  videoOutputPath: string
  wasAudioFile?: boolean // default false
  deleteWebInputVideoFile?: MVideoFile
    Severity: Minor
    Found in server/core/lib/transcoding/web-transcoding.ts - About 1 hr to fix

      Function optimizeOriginalVideofile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function optimizeOriginalVideofile (options: {
  video: MVideoFullLight
  quickTranscode: boolean
  job: Job
}) {
      Severity: Minor
      Found in server/core/lib/transcoding/web-transcoding.ts - About 1 hr to fix

        Function result has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const result = await VideoPathManager.Instance.makeAvailableVideoFile(inputVideoFile, async audioInputPath => {
      const videoOutputPath = join(transcodeDirectory, video.id + '-transcoded' + newExtname)

      // If the user updates the video preview during transcoding
      const previewPath = video.getPreview().getPath()
        Severity: Minor
        Found in server/core/lib/transcoding/web-transcoding.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                const transcodeOptions: VideoTranscodeOptions = {
        type: 'video',

        videoInputPath: videoPath,
        separatedAudioInputPath: separatedAudioPath,
          Severity: Minor
          Found in server/core/lib/transcoding/web-transcoding.ts and 1 other location - About 40 mins to fix
          server/core/lib/transcoding/web-transcoding.ts on lines 151..163

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                const transcodeOptions: MergeAudioTranscodeOptions = {
        type: 'merge-audio',

        videoInputPath: tmpPreviewPath,
        audioPath: audioInputPath,
          Severity: Minor
          Found in server/core/lib/transcoding/web-transcoding.ts and 1 other location - About 40 mins to fix
          server/core/lib/transcoding/web-transcoding.ts on lines 100..112

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status