Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/user.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function createUserAccountAndChannelAndPlaylist has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function createUserAccountAndChannelAndPlaylist (parameters: {
  userToCreate: MUser
  userDisplayName?: string
  channelNames?: ChannelNames
  validateUser?: boolean
Severity: Minor
Found in server/core/lib/user.ts - About 1 hr to fix

    Function buildUser has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function buildUser (options: {
  username: string
  password: string
  email: string
    Severity: Minor
    Found in server/core/lib/user.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      async function getOriginalVideoFileTotalDailyFromUser (user: MUserId) {
  const base = await UserModel.getUserQuota({ userId: user.id, daily: true })

  return base + LiveQuotaStore.Instance.getLiveQuotaOfUser(user.id)
}
      Severity: Major
      Found in server/core/lib/user.ts and 1 other location - About 1 hr to fix
      server/core/lib/user.ts on lines 198..202

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      async function getOriginalVideoFileTotalFromUser (user: MUserId) {
  const base = await UserModel.getUserQuota({ userId: user.id, daily: false })

  return base + LiveQuotaStore.Instance.getLiveQuotaOfUser(user.id)
}
      Severity: Major
      Found in server/core/lib/user.ts and 1 other location - About 1 hr to fix
      server/core/lib/user.ts on lines 205..209

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status