Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/video-file.ts

Summary

Maintainability
F
3 days
Test Coverage

File video-file.ts has 305 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  FFmpegContainer,
  ffprobePromise,
  getVideoStreamDimensionsInfo,
  getVideoStreamFPS,
Severity: Minor
Found in server/core/lib/video-file.ts - About 3 hrs to fix

    Function muxToMergeVideoFiles has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    export async function muxToMergeVideoFiles (options: {
  video: MVideoThumbnail
  videoFiles: MVideoFile[]
  output: Writable
}) {
    Severity: Minor
    Found in server/core/lib/video-file.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function muxToMergeVideoFiles has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function muxToMergeVideoFiles (options: {
  video: MVideoThumbnail
  videoFiles: MVideoFile[]
  output: Writable
}) {
    Severity: Minor
    Found in server/core/lib/video-file.ts - About 1 hr to fix

      Function buildMuxInput has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      async function buildMuxInput (
  video: MVideo,
  videoFile: MVideoFile
): Promise<{ input: Readable, isTmpDestination: false } | { input: string, isTmpDestination: boolean }> {
      Severity: Minor
      Found in server/core/lib/video-file.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function buildMuxInput has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function buildMuxInput (
  video: MVideo,
  videoFile: MVideoFile
): Promise<{ input: Readable, isTmpDestination: false } | { input: string, isTmpDestination: boolean }> {
      Severity: Minor
      Found in server/core/lib/video-file.ts - About 1 hr to fix

        Function saveNewOriginalFileIfNeeded has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export async function saveNewOriginalFileIfNeeded (video: MVideo, videoFile: MVideoFile) {
  if (!CONFIG.TRANSCODING.ORIGINAL_FILE.KEEP) return

  const videoSource = await VideoSourceModel.loadLatest(video.id)
        Severity: Minor
        Found in server/core/lib/video-file.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildNewFile has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export async function buildNewFile (options: {
  path: string
  mode: 'web-video' | 'hls'
  ffprobe?: FfprobeData
}): Promise<MVideoFile> {
        Severity: Minor
        Found in server/core/lib/video-file.ts - About 1 hr to fix

          Function saveNewOriginalFileIfNeeded has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export async function saveNewOriginalFileIfNeeded (video: MVideo, videoFile: MVideoFile) {
  if (!CONFIG.TRANSCODING.ORIGINAL_FILE.KEEP) return

  const videoSource = await VideoSourceModel.loadLatest(video.id)
          Severity: Minor
          Found in server/core/lib/video-file.ts - About 1 hr to fix

            Function buildNewFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export async function buildNewFile (options: {
  path: string
  mode: 'web-video' | 'hls'
  ffprobe?: FfprobeData
}): Promise<MVideoFile> {
            Severity: Minor
            Found in server/core/lib/video-file.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

              return { input: stream, isTmpDestination: false }
            Severity: Major
            Found in server/core/lib/video-file.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return { input: stream, isTmpDestination: false }
              Severity: Major
              Found in server/core/lib/video-file.ts - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (await isAudioFile(inputPath, probe)) {
      videoSource.fps = 0
      videoSource.resolution = VideoResolution.H_NOVIDEO
      videoSource.width = 0
      videoSource.height = 0
                Severity: Major
                Found in server/core/lib/video-file.ts and 1 other location - About 5 hrs to fix
                server/core/lib/video-file.ts on lines 64..75

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 143.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  if (await isAudioFile(path, probe)) {
    videoFile.fps = 0
    videoFile.resolution = VideoResolution.H_NOVIDEO
    videoFile.width = 0
    videoFile.height = 0
                Severity: Major
                Found in server/core/lib/video-file.ts and 1 other location - About 5 hrs to fix
                server/core/lib/video-file.ts on lines 200..211

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 143.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status