Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/video-pre-import.ts

Summary

Maintainability
C
1 day
Test Coverage

Function buildYoutubeDLImport has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function buildYoutubeDLImport (options: {
  targetUrl: string
  channel: MChannelAccountDefault
  user: MUser
  channelSync?: MChannelSync
Severity: Major
Found in server/core/lib/video-pre-import.ts - About 3 hrs to fix

    File video-pre-import.ts has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  ThumbnailType,
  ThumbnailType_Type,
  VideoImportCreate,
  VideoImportPayload,
    Severity: Minor
    Found in server/core/lib/video-pre-import.ts - About 2 hrs to fix

      Function insertFromImportIntoDB has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function insertFromImportIntoDB (parameters: {
  video: MVideoThumbnail
  thumbnailModel: MThumbnail
  previewModel: MThumbnail
  videoChannel: MChannelAccountDefault
      Severity: Minor
      Found in server/core/lib/video-pre-import.ts - About 1 hr to fix

        Function buildVideoFromImport has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        async function buildVideoFromImport ({ channelId, importData, importDataOverride, importType }: {
  channelId: number
  importData: YoutubeDLInfo
  importDataOverride?: Partial<VideoImportCreate>
  importType: 'url' | 'torrent'
        Severity: Minor
        Found in server/core/lib/video-pre-import.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function insertFromImportIntoDB has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        async function insertFromImportIntoDB (parameters: {
  video: MVideoThumbnail
  thumbnailModel: MThumbnail
  previewModel: MThumbnail
  videoChannel: MChannelAccountDefault
        Severity: Minor
        Found in server/core/lib/video-pre-import.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          const { video, thumbnailModel, previewModel, videoChannel, tags, videoImportAttributes, user, videoPasswords } = parameters
        Severity: Major
        Found in server/core/lib/video-pre-import.ts and 3 other locations - About 40 mins to fix
        server/core/controllers/feeds/shared/common-feed-utils.ts on lines 34..34
        server/core/lib/job-queue/handlers/shared/move-video.ts on lines 20..29
        server/core/lib/runners/job-handlers/live-rtmp-hls-transcoding-job-handler.ts on lines 42..42

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status