Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/middlewares/activitypub.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function checkHttpSignature has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function checkHttpSignature (req: Request, res: Response) {
  return wrapWithSpanAndContext('peertube.activitypub.checkHTTPSignature', async () => {
    // FIXME: compatibility with http-signature < v1.3
    const sig = req.headers[HTTP_SIGNATURE.HEADER_NAME] as string
    if (sig && sig.startsWith('Signature ') === true) req.headers[HTTP_SIGNATURE.HEADER_NAME] = sig.replace(/^Signature /, '')
Severity: Minor
Found in server/core/middlewares/activitypub.ts - About 1 hr to fix

    Function checkSignature has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export async function checkSignature (req: Request, res: Response, next: NextFunction) {
  try {
    const httpSignatureChecked = await checkHttpSignature(req, res)
    if (httpSignatureChecked !== true) return
    Severity: Minor
    Found in server/core/middlewares/activitypub.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return res.fail({
      status: HttpStatusCode.FORBIDDEN_403,
      message: 'ActivityPub signature could not be checked'
    })
    Severity: Major
    Found in server/core/middlewares/activitypub.ts - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status