Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/middlewares/validators/oembed.ts

Summary

Maintainability
C
1 day
Test Coverage

Function oembedValidator has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async (req: express.Request, res: express.Response, next: express.NextFunction) => {
    if (areValidationErrors(req, res)) return

    if (req.query.format !== undefined && req.query.format !== 'json') {
      return res.fail({
Severity: Major
Found in server/core/middlewares/validators/oembed.ts - About 3 hrs to fix

    Function oembedValidator has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      async (req: express.Request, res: express.Response, next: express.NextFunction) => {
    if (areValidationErrors(req, res)) return

    if (req.query.format !== undefined && req.query.format !== 'json') {
      return res.fail({
    Severity: Minor
    Found in server/core/middlewares/validators/oembed.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return res.fail({
          status: HttpStatusCode.NOT_FOUND_404,
          message: 'Video not found'
        })
    Severity: Major
    Found in server/core/middlewares/validators/oembed.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return res.fail({
        status: HttpStatusCode.NOT_FOUND_404,
        message: 'Video playlist not found'
      })
      Severity: Major
      Found in server/core/middlewares/validators/oembed.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return next()
        Severity: Major
        Found in server/core/middlewares/validators/oembed.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return res.fail({ message: 'Invalid video or playlist id.' })
          Severity: Major
          Found in server/core/middlewares/validators/oembed.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return res.fail({
        status: HttpStatusCode.FORBIDDEN_403,
        message: 'Video is not publicly available'
      })
            Severity: Major
            Found in server/core/middlewares/validators/oembed.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return res.fail({
      status: HttpStatusCode.FORBIDDEN_403,
      message: 'Playlist is not public'
    })
              Severity: Major
              Found in server/core/middlewares/validators/oembed.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return next()
                Severity: Major
                Found in server/core/middlewares/validators/oembed.ts - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status