Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/middlewares/validators/users/user-import.ts

Summary

Maintainability
C
1 day
Test Coverage

Function userImportRequestResumableInitValidator has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async (req: express.Request, res: express.Response, next: express.NextFunction) => {
    if (areValidationErrors(req, res)) return

    if (CONFIG.IMPORT.USERS.ENABLED !== true) {
      return res.fail({
Severity: Minor
Found in server/core/middlewares/validators/users/user-import.ts - About 1 hr to fix

    Function userImportRequestResumableInitValidator has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      async (req: express.Request, res: express.Response, next: express.NextFunction) => {
    if (areValidationErrors(req, res)) return

    if (CONFIG.IMPORT.USERS.ENABLED !== true) {
      return res.fail({
    Severity: Minor
    Found in server/core/middlewares/validators/users/user-import.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return res.fail({
        message: 'User video quota is exceeded with this import',
        status: HttpStatusCode.PAYLOAD_TOO_LARGE_413,
        type: ServerErrorCode.QUOTA_REACHED
      })
    Severity: Major
    Found in server/core/middlewares/validators/users/user-import.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return next()
      Severity: Major
      Found in server/core/middlewares/validators/users/user-import.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return res.fail({
        message: 'An import is already being processed',
        status: HttpStatusCode.BAD_REQUEST_400
      })
        Severity: Major
        Found in server/core/middlewares/validators/users/user-import.ts - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          async function checkUserIdRight (userId: number | string, res: express.Response) {
  if (!await checkUserIdExist(userId, res)) return false

  const oauthUser = res.locals.oauth.token.User
          Severity: Major
          Found in server/core/middlewares/validators/users/user-import.ts and 1 other location - About 5 hrs to fix
          server/core/middlewares/validators/users/user-exports.ts on lines 116..130

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 147.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            async (req: express.Request, res: express.Response, next: express.NextFunction) => {
    if (!await checkUserIdRight(req.params.userId, res)) return

    return next()
  }
          Severity: Major
          Found in server/core/middlewares/validators/users/user-import.ts and 1 other location - About 1 hr to fix
          server/core/middlewares/validators/videos/video-channels.ts on lines 78..82

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (CONFIG.IMPORT.USERS.ENABLED !== true) {
      return res.fail({
        message: 'User import is not enabled by the administrator',
        status: HttpStatusCode.BAD_REQUEST_400
      })
          Severity: Minor
          Found in server/core/middlewares/validators/users/user-import.ts and 1 other location - About 40 mins to fix
          server/core/middlewares/validators/object-storage-proxy.ts on lines 7..12

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status