Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/middlewares/validators/videos/video-captions.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function generateVideoCaptionValidator has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async (req: express.Request, res: express.Response, next: express.NextFunction) => {
    if (areValidationErrors(req, res)) return

    if (CONFIG.VIDEO_TRANSCRIPTION.ENABLED !== true) {
      return res.fail({
Severity: Minor
Found in server/core/middlewares/validators/videos/video-captions.ts - About 1 hr to fix

    Function generateVideoCaptionValidator has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      async (req: express.Request, res: express.Response, next: express.NextFunction) => {
    if (areValidationErrors(req, res)) return

    if (CONFIG.VIDEO_TRANSCRIPTION.ENABLED !== true) {
      return res.fail({
    Severity: Minor
    Found in server/core/middlewares/validators/videos/video-captions.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return next()
    Severity: Major
    Found in server/core/middlewares/validators/videos/video-captions.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return next()
      Severity: Major
      Found in server/core/middlewares/validators/videos/video-captions.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            if (!checkUserCanManageVideo(user, video, UserRight.UPDATE_ANY_VIDEO, res)) return
        Severity: Major
        Found in server/core/middlewares/validators/videos/video-captions.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return res.fail({
          status: HttpStatusCode.FORBIDDEN_403,
          message: 'Only admins can force transcription'
        })
          Severity: Major
          Found in server/core/middlewares/validators/videos/video-captions.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return next()
            Severity: Major
            Found in server/core/middlewares/validators/videos/video-captions.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return res.fail({
        status: HttpStatusCode.BAD_REQUEST_400,
        type: ServerErrorCode.VIDEO_ALREADY_HAS_CAPTIONS,
        message: 'This video already has captions'
      })
              Severity: Major
              Found in server/core/middlewares/validators/videos/video-captions.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return res.fail({
        status: HttpStatusCode.CONFLICT_409,
        type: ServerErrorCode.VIDEO_ALREADY_BEING_TRANSCRIBED,
        message: 'This video is already being transcribed'
      })
                Severity: Major
                Found in server/core/middlewares/validators/videos/video-captions.ts - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (info && info.pendingTranscription > 0) {
      return res.fail({
        status: HttpStatusCode.CONFLICT_409,
        type: ServerErrorCode.VIDEO_ALREADY_BEING_TRANSCRIBED,
        message: 'This video is already being transcribed'
                  Severity: Minor
                  Found in server/core/middlewares/validators/videos/video-captions.ts and 1 other location - About 55 mins to fix
                  server/core/middlewares/validators/videos/video-transcoding.ts on lines 41..47

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      if (CONFIG.VIDEO_TRANSCRIPTION.ENABLED !== true) {
      return res.fail({
        status: HttpStatusCode.BAD_REQUEST_400,
        message: 'Video transcription is disabled on this instance'
      })
                  Severity: Major
                  Found in server/core/middlewares/validators/videos/video-captions.ts and 3 other locations - About 30 mins to fix
                  server/core/middlewares/validators/server.ts on lines 43..48
                  server/core/middlewares/validators/users/user-registrations.ts on lines 26..31
                  server/core/middlewares/validators/videos/video-transcoding.ts on lines 30..35

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status