Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/middlewares/validators/videos/video-comments.ts

Summary

Maintainability
F
3 days
Test Coverage

File video-comments.ts has 276 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { arrayify } from '@peertube/peertube-core-utils'
import { HttpStatusCode, UserRight, VideoCommentPolicy } from '@peertube/peertube-models'
import { isStringArray } from '@server/helpers/custom-validators/search.js'
import { canVideoBeFederated } from '@server/lib/activitypub/videos/federate.js'
import { MUserAccountUrl } from '@server/types/models/index.js'
Severity: Minor
Found in server/core/middlewares/validators/videos/video-comments.ts - About 2 hrs to fix

    Function isVideoCommentAccepted has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function isVideoCommentAccepted (req: express.Request, res: express.Response, video: MVideoFullLight, isReply: boolean) {
  const acceptParameters = {
    video,
    commentBody: req.body,
    user: res.locals.oauth.token.User,
    Severity: Minor
    Found in server/core/middlewares/validators/videos/video-comments.ts - About 1 hr to fix

      Function checkUserCanApproveVideoComment has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function checkUserCanApproveVideoComment (user: MUserAccountUrl, videoComment: MCommentOwnerVideoReply, res: express.Response) {
  if (videoComment.isDeleted()) {
    res.fail({
      status: HttpStatusCode.CONFLICT_409,
      message: 'This comment is deleted'
      Severity: Minor
      Found in server/core/middlewares/validators/videos/video-comments.ts - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

            return next()
        Severity: Major
        Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (channel && !checkUserCanManageAccount({ account: channel.Account, user, res, specialRight: UserRight.SEE_ALL_COMMENTS })) return
          Severity: Major
          Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                if (!await isVideoCommentAccepted(req, res, res.locals.videoAll, true)) return
            Severity: Major
            Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return next()
              Severity: Major
              Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return next()
                Severity: Major
                Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return next()
                  Severity: Major
                  Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return next()
                    Severity: Major
                    Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return next()
                      Severity: Major
                      Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            if (!await isVideoCommentAccepted(req, res, res.locals.videoAll, false)) return
                        Severity: Major
                        Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              if (!await doesVideoCommentExist(req.params.commentId, res.locals.videoAll, res)) return
                          Severity: Major
                          Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return next()
                            Severity: Major
                            Found in server/core/middlewares/validators/videos/video-comments.ts - About 30 mins to fix

                              Function addVideoCommentReplyValidator has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                async (req: express.Request, res: express.Response, next: express.NextFunction) => {
    if (areValidationErrors(req, res)) return
    if (!await doesVideoExist(req.params.videoId, res)) return

    if (!await checkCanSeeVideo({ req, res, paramId: req.params.videoId, video: res.locals.videoAll })) return
                              Severity: Minor
                              Found in server/core/middlewares/validators/videos/video-comments.ts - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              export const removeVideoCommentValidator = [
  isValidVideoIdParam('videoId'),

  param('commentId')
    .custom(isIdValid),
                              Severity: Major
                              Found in server/core/middlewares/validators/videos/video-comments.ts and 1 other location - About 6 hrs to fix
                              server/core/middlewares/validators/videos/video-comments.ts on lines 198..213

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 172.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              export const approveVideoCommentValidator = [
  isValidVideoIdParam('videoId'),

  param('commentId')
    .custom(isIdValid),
                              Severity: Major
                              Found in server/core/middlewares/validators/videos/video-comments.ts and 1 other location - About 6 hrs to fix
                              server/core/middlewares/validators/videos/video-comments.ts on lines 181..196

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 172.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              function isVideoCommentsEnabled (video: MVideo, res: express.Response) {
  if (video.commentsPolicy === VideoCommentPolicy.DISABLED) {
    res.fail({
      status: HttpStatusCode.CONFLICT_409,
      message: 'Video comments are disabled for this video.'
                              Severity: Minor
                              Found in server/core/middlewares/validators/videos/video-comments.ts and 1 other location - About 55 mins to fix
                              server/core/middlewares/validators/videos/video-ownership-changes.ts on lines 84..96

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 54.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                  if (!await checkCanSeeVideo({ req, res, paramId: req.params.videoId, video: res.locals.onlyVideo })) return
                              Severity: Major
                              Found in server/core/middlewares/validators/videos/video-comments.ts and 5 other locations - About 45 mins to fix
                              server/core/middlewares/validators/feeds.ts on lines 150..150
                              server/core/middlewares/validators/videos/video-comments.ts on lines 115..115
                              server/core/middlewares/validators/videos/video-comments.ts on lines 132..132
                              server/core/middlewares/validators/videos/video-comments.ts on lines 153..153
                              server/core/middlewares/validators/videos/video-rates.ts on lines 23..23

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 50.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                  if (!await checkCanSeeVideo({ req, res, paramId: req.params.videoId, video: res.locals.videoAll })) return
                              Severity: Major
                              Found in server/core/middlewares/validators/videos/video-comments.ts and 5 other locations - About 45 mins to fix
                              server/core/middlewares/validators/feeds.ts on lines 150..150
                              server/core/middlewares/validators/videos/video-comments.ts on lines 97..97
                              server/core/middlewares/validators/videos/video-comments.ts on lines 115..115
                              server/core/middlewares/validators/videos/video-comments.ts on lines 132..132
                              server/core/middlewares/validators/videos/video-rates.ts on lines 23..23

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 50.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                  if (!await checkCanSeeVideo({ req, res, paramId: req.params.videoId, video: res.locals.onlyVideo })) return
                              Severity: Major
                              Found in server/core/middlewares/validators/videos/video-comments.ts and 5 other locations - About 45 mins to fix
                              server/core/middlewares/validators/feeds.ts on lines 150..150
                              server/core/middlewares/validators/videos/video-comments.ts on lines 97..97
                              server/core/middlewares/validators/videos/video-comments.ts on lines 132..132
                              server/core/middlewares/validators/videos/video-comments.ts on lines 153..153
                              server/core/middlewares/validators/videos/video-rates.ts on lines 23..23

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 50.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                  if (!await checkCanSeeVideo({ req, res, paramId: req.params.videoId, video: res.locals.videoAll })) return
                              Severity: Major
                              Found in server/core/middlewares/validators/videos/video-comments.ts and 5 other locations - About 45 mins to fix
                              server/core/middlewares/validators/feeds.ts on lines 150..150
                              server/core/middlewares/validators/videos/video-comments.ts on lines 97..97
                              server/core/middlewares/validators/videos/video-comments.ts on lines 115..115
                              server/core/middlewares/validators/videos/video-comments.ts on lines 153..153
                              server/core/middlewares/validators/videos/video-rates.ts on lines 23..23

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 50.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status