Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/models/abuse/sql/abuse-query-builder.ts

Summary

Maintainability
C
1 day
Test Coverage

Function buildAbuseListQuery has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function buildAbuseListQuery (options: BuildAbusesQueryOptions, type: 'count' | 'id') {
  const whereAnd: string[] = []
  const replacements: any = {}

  const joins = [
Severity: Major
Found in server/core/models/abuse/sql/abuse-query-builder.ts - About 3 hrs to fix

    Function buildAbuseListQuery has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    function buildAbuseListQuery (options: BuildAbusesQueryOptions, type: 'count' | 'id') {
  const whereAnd: string[] = []
  const replacements: any = {}

  const joins = [
    Severity: Minor
    Found in server/core/models/abuse/sql/abuse-query-builder.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (options.videoIs === 'deleted') {
    whereAnd.push('"videoAbuse"."deletedVideo" IS NOT NULL')
  } else if (options.videoIs === 'blacklisted') {
    whereAnd.push('"videoBlacklist"."id" IS NOT NULL')
  }
    Severity: Minor
    Found in server/core/models/abuse/sql/abuse-query-builder.ts and 1 other location - About 55 mins to fix
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 109..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      } else if (options.filter === 'comment') {
    whereAnd.push('"commentAbuse"."id" IS NOT NULL')
  } else if (options.filter === 'account') {
    whereAnd.push('"videoAbuse"."id" IS NULL AND "commentAbuse"."id" IS NULL')
  }
    Severity: Minor
    Found in server/core/models/abuse/sql/abuse-query-builder.ts and 1 other location - About 55 mins to fix
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 96..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      if (options.searchReportee) {
    whereAnd.push('"flaggedAccount"."name" ILIKE :searchReportee')
    replacements.searchReportee = `%${options.searchReportee}%`
  }
    Severity: Major
    Found in server/core/models/abuse/sql/abuse-query-builder.ts and 3 other locations - About 35 mins to fix
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 76..79
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 81..84
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 115..118

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      if (options.searchReporter) {
    whereAnd.push('"reporterAccount"."name" ILIKE :searchReporter')
    replacements.searchReporter = `%${options.searchReporter}%`
  }
    Severity: Major
    Found in server/core/models/abuse/sql/abuse-query-builder.ts and 3 other locations - About 35 mins to fix
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 76..79
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 81..84
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 120..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      if (options.searchVideoChannel) {
    whereAnd.push('"videoChannel"."name" ILIKE :searchVideoChannel')
    replacements.searchVideoChannel = `%${options.searchVideoChannel}%`
  }
    Severity: Major
    Found in server/core/models/abuse/sql/abuse-query-builder.ts and 3 other locations - About 35 mins to fix
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 76..79
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 115..118
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 120..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      if (options.searchVideo) {
    whereAnd.push('"video"."name" ILIKE :searchVideo')
    replacements.searchVideo = `%${options.searchVideo}%`
  }
    Severity: Major
    Found in server/core/models/abuse/sql/abuse-query-builder.ts and 3 other locations - About 35 mins to fix
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 81..84
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 115..118
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 120..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (exists(options.count)) {
      const count = forceNumber(options.count)
      suffix += `LIMIT ${count} `
    }
    Severity: Minor
    Found in server/core/models/abuse/sql/abuse-query-builder.ts and 1 other location - About 35 mins to fix
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 142..145

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (exists(options.start)) {
      const start = forceNumber(options.start)
      suffix += `OFFSET ${start} `
    }
    Severity: Minor
    Found in server/core/models/abuse/sql/abuse-query-builder.ts and 1 other location - About 35 mins to fix
    server/core/models/abuse/sql/abuse-query-builder.ts on lines 137..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status