Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/models/shared/model-builder.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function createModel has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  private createModel (json: any, modelName: string, keyPath: string) {
    if (!json.id) return { created: false, model: null }

    const { created, model } = this.createOrFindModel(json, modelName, keyPath)
Severity: Minor
Found in server/core/models/shared/model-builder.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    if (modelName === 'CommentAutomaticTags') return 'CommentAutomaticTagModel'
Severity: Major
Found in server/core/models/shared/model-builder.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return modelName + 'Model'
    Severity: Major
    Found in server/core/models/shared/model-builder.ts - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status