ChrisBAshton/smartresolution

View on GitHub

Showing 43 of 82 total issues

Function datetimepicker has 1051 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $.fn.datetimepicker = function (opt) {
        var KEY0 = 48,
            KEY9 = 57,
            _KEY0 = 96,
            _KEY9 = 105,
Severity: Major
Found in webapp/core/view/js/jquery.datetimepicker.js - About 5 days to fix

    File jquery.datetimepicker.js has 1705 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * @preserve jQuery DateTimePicker plugin v2.4.1
     * @homepage http://xdsoft.net/jqplugins/datetimepicker/
     * (c) 2014, Chupurnov Valeriy.
     */
    Severity: Major
    Found in webapp/core/view/js/jquery.datetimepicker.js - About 4 days to fix

      Function setOptions has 194 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  datetimepicker.setOptions = function (_options) {
                      options = $.extend(true, {}, options, _options);
      
                      if (_options.allowTimes && $.isArray(_options.allowTimes) && _options.allowTimes.length) {
                          options.allowTimes = $.extend(true, [], _options.allowTimes);
      Severity: Major
      Found in webapp/core/view/js/jquery.datetimepicker.js - About 7 hrs to fix

        Function xdsoftScroller has 141 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $.fn.xdsoftScroller = function (percent) {
                return this.each(function () {
                    var timeboxparent = $(this),
                        pointerEventToXY = function (e) {
                            var out = {x: 0, y: 0},
        Severity: Major
        Found in webapp/core/view/js/jquery.datetimepicker.js - About 5 hrs to fix

          Consider simplifying this complex logical expression.
          Open

                                      if (((key >= KEY0 && key <= KEY9) || (key >= _KEY0 && key <= _KEY9)) || (key === BACKSPACE || key === DEL)) {
                                          pos = getCaretPos(this);
                                          digit = (key !== BACKSPACE && key !== DEL) ? String.fromCharCode((_KEY0 <= key && key <= _KEY9) ? key - KEY0 : key) : '_';
          
                                          if ((key === BACKSPACE || key === DEL) && pos) {
          Severity: Critical
          Found in webapp/core/view/js/jquery.datetimepicker.js - About 3 hrs to fix

            Consider simplifying this complex logical expression.
            Open

            !function(a){"function"==typeof define&&define.amd?define(["jquery"],a):"object"==typeof exports?module.exports=a:a(jQuery)}(function(a){function b(b){var g=b||window.event,h=i.call(arguments,1),j=0,l=0,m=0,n=0,o=0,p=0;if(b=a.event.fix(g),b.type="mousewheel","detail"in g&&(m=-1*g.detail),"wheelDelta"in g&&(m=g.wheelDelta),"wheelDeltaY"in g&&(m=g.wheelDeltaY),"wheelDeltaX"in g&&(l=-1*g.wheelDeltaX),"axis"in g&&g.axis===g.HORIZONTAL_AXIS&&(l=-1*m,m=0),j=0===m?l:m,"deltaY"in g&&(m=-1*g.deltaY,j=m),"deltaX"in g&&(l=g.deltaX,0===m&&(j=-1*l)),0!==m||0!==l){if(1===g.deltaMode){var q=a.data(this,"mousewheel-line-height");j*=q,m*=q,l*=q}else if(2===g.deltaMode){var r=a.data(this,"mousewheel-page-height");j*=r,m*=r,l*=r}if(n=Math.max(Math.abs(m),Math.abs(l)),(!f||f>n)&&(f=n,d(g,n)&&(f/=40)),d(g,n)&&(j/=40,l/=40,m/=40),j=Math[j>=1?"floor":"ceil"](j/f),l=Math[l>=1?"floor":"ceil"](l/f),m=Math[m>=1?"floor":"ceil"](m/f),k.settings.normalizeOffset&&this.getBoundingClientRect){var s=this.getBoundingClientRect();o=b.clientX-s.left,p=b.clientY-s.top}return b.deltaX=l,b.deltaY=m,b.deltaFactor=f,b.offsetX=o,b.offsetY=p,b.deltaMode=0,h.unshift(b,j,l,m),e&&clearTimeout(e),e=setTimeout(c,200),(a.event.dispatch||a.event.handle).apply(this,h)}}function c(){f=null}function d(a,b){return k.settings.adjustOldDeltas&&"mousewheel"===a.type&&b%120===0}var e,f,g=["wheel","mousewheel","DOMMouseScroll","MozMousePixelScroll"],h="onwheel"in document||document.documentMode>=9?["wheel"]:["mousewheel","DomMouseScroll","MozMousePixelScroll"],i=Array.prototype.slice;if(a.event.fixHooks)for(var j=g.length;j;)a.event.fixHooks[g[--j]]=a.event.mouseHooks;var k=a.event.special.mousewheel={version:"3.1.12",setup:function(){if(this.addEventListener)for(var c=h.length;c;)this.addEventListener(h[--c],b,!1);else this.onmousewheel=b;a.data(this,"mousewheel-line-height",k.getLineHeight(this)),a.data(this,"mousewheel-page-height",k.getPageHeight(this))},teardown:function(){if(this.removeEventListener)for(var c=h.length;c;)this.removeEventListener(h[--c],b,!1);else this.onmousewheel=null;a.removeData(this,"mousewheel-line-height"),a.removeData(this,"mousewheel-page-height")},getLineHeight:function(b){var c=a(b),d=c["offsetParent"in a.fn?"offsetParent":"parent"]();return d.length||(d=a("body")),parseInt(d.css("fontSize"),10)||parseInt(c.css("fontSize"),10)||16},getPageHeight:function(b){return a(b).height()},settings:{adjustOldDeltas:!0,normalizeOffset:!0}};a.fn.extend({mousewheel:function(a){return a?this.bind("mousewheel",a):this.trigger("mousewheel")},unmousewheel:function(a){return this.unbind("mousewheel",a)}})});
            Severity: Critical
            Found in webapp/core/view/js/jquery.datetimepicker.js - About 3 hrs to fix

              Dispute has 25 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Dispute {
              
                  private $disputeID;
                  private $type;
                  private $title;
              Severity: Minor
              Found in webapp/core/model/Dispute.php - About 2 hrs to fix

                Method setDefaultActions has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function setDefaultActions($dispute, $account) {
                        global $dashboardActions;
                        $dashboardActions = array();
                        $state = $dispute->getState($account);
                
                
                Severity: Major
                Found in webapp/core/helpers/DisputeStateCalculator.php - About 2 hrs to fix

                  Function status has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function status() {
                          if ($this->isEnded()) {
                              $status = 'Dispute ended.';
                          }
                          else if ($this->accepted()) {
                  Severity: Minor
                  Found in webapp/core/model/Lifespan.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function calculateStateClass has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function calculateStateClass($dispute) {
                          if ($dispute->getStatus() !== 'ongoing') {
                              return "DisputeClosed";
                          }
                  
                  
                  Severity: Minor
                  Found in webapp/core/helpers/DisputeStateCalculator.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function rrmdir has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                      function rrmdir($dir) {
                          if (is_dir($dir)) {
                              $objects = scandir($dir);
                              foreach ($objects as $object) {
                                  if ($object != "." && $object != "..") {
                  Severity: Minor
                  Found in webapp/core/controller/AdminController.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method dispute has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function dispute($details) {
                          $lawFirmA = (int) Utils::instance()->getValue($details, 'law_firm_a');
                          $type     = Utils::instance()->getValue($details, 'type');
                          $title    = Utils::instance()->getValue($details, 'title');
                          $agentA   = isset($details['agent_a']) ? $details['agent_a'] : NULL;
                  Severity: Minor
                  Found in webapp/core/db/DBCreate.php - About 1 hr to fix

                    Method upload has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function upload ($f3, $params) {
                            $account = mustBeLoggedIn();
                            $dispute = setDisputeFromParams($f3, $params);
                    
                            if (!$dispute->getState()->canUploadDocuments()) {
                    Severity: Minor
                    Found in webapp/core/controller/EvidenceController.php - About 1 hr to fix

                      Method calculateStateClass has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function calculateStateClass($dispute) {
                              if ($dispute->getStatus() !== 'ongoing') {
                                  return "DisputeClosed";
                              }
                      
                      
                      Severity: Minor
                      Found in webapp/core/helpers/DisputeStateCalculator.php - About 1 hr to fix

                        Method disputeParty has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function disputeParty($disputeParty) {
                                if (!$disputeParty->getPartyId()) {
                                    $createdParty = DBCreate::instance()->disputeParty(array(
                                        'organisation_id' => $disputeParty->getLawFirmID()
                                    ));
                        Severity: Minor
                        Found in webapp/core/db/DBUpdate.php - About 1 hr to fix

                          Function line_time has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                                  line_time = function line_time(h, m) {
                                                      var now = _xdsoft_datetime.now();
                                                      now.setHours(h);
                                                      h = parseInt(now.getHours(), 10);
                                                      now.setMinutes(m);
                          Severity: Minor
                          Found in webapp/core/view/js/jquery.datetimepicker.js - About 1 hr to fix

                            Method individualPost has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                function individualPost ($f3) {
                                    mustBeLoggedInAsAn('Organisation');
                            
                                    $email    = $f3->get('POST.email');
                                    $password = $f3->get('POST.password');
                            Severity: Minor
                            Found in webapp/core/controller/RegisterController.php - About 1 hr to fix

                              Consider simplifying this complex logical expression.
                              Open

                                                  } else if (e.type === 'mousedown' || e.type === 'mouseup' || e.type === 'mousemove' || e.type === 'mouseover' || e.type === 'mouseout' || e.type === 'mouseenter' || e.type === 'mouseleave') {
                                                      out.x = e.clientX;
                                                      out.y = e.clientY;
                                                  }
                              Severity: Major
                              Found in webapp/core/view/js/jquery.datetimepicker.js - About 1 hr to fix

                                Function invalid has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function invalid($validUntil, $startTime, $endTime) {
                                        $currentTime = time();
                                        $invalidBecause = false;
                                
                                        if ($validUntil < $currentTime || $startTime < $currentTime || $endTime < $currentTime) {
                                Severity: Minor
                                Found in webapp/core/model/Lifespan.php - About 55 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function accountDetails has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function accountDetails($loginID) {
                                        $individual    = $this->getAccountRowByLoginId('individuals',    $loginID);
                                        $organisation  = $this->getAccountRowByLoginId('organisations',  $loginID);
                                        $administrator = $this->getAccountRowByLoginId('administrators', $loginID);
                                        $details       = false;
                                Severity: Minor
                                Found in webapp/core/db/DBGet.php - About 55 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language