ChrisBAshton/smartresolution

View on GitHub

Showing 43 of 82 total issues

Function view has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    function view ($f3, $params) {
        $account = mustBeLoggedInAsAn('Agent');
        $dispute = setDisputeFromParams($f3, $params);

        if ($dispute->getLatestLifespan()->accepted()) {
Severity: Minor
Found in webapp/core/controller/LifespanController.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setUp has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private function setUp($f3, $params) {
        $this->account = mustBeLoggedInAsAn('Individual');
        $this->dispute = setDisputeFromParams($f3, $params);

        if (!$this->dispute->canBeViewedBy($this->account->getLoginId())) {
Severity: Minor
Found in webapp/core/controller/MessageController.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setDefaultActions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function setDefaultActions($dispute, $account) {
        global $dashboardActions;
        $dashboardActions = array();
        $state = $dispute->getState($account);

Severity: Minor
Found in webapp/core/helpers/DisputeStateCalculator.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                                    if (pos === options.mask.length) {
                                        event.preventDefault();
                                        return false;
                                    }
Severity: Major
Found in webapp/core/view/js/jquery.datetimepicker.js - About 45 mins to fix

    Consider simplifying this complex logical expression.
    Open

            if (!$title || !$agent || !$type  || !$summary || $agent === '---' || $type === '---') {
                $f3->set('error_message', 'Please fill in all fields.');
            }
            else {
                try {
    Severity: Major
    Found in webapp/core/controller/DisputeController.php - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

                                  if ((maxDate !== false && start > maxDate) || (minDate !== false && start < minDate) || (customDateSettings && customDateSettings[0] === false)) {
                                      classes.push('xdsoft_disabled');
                                  } else if (options.disabledDates.indexOf(start.dateFormat(options.formatDate)) !== -1) {
                                      classes.push('xdsoft_disabled');
                                  }
      Severity: Major
      Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

        Consider simplifying this complex logical expression.
        Open

                                    if((options.minDateTime !== false && options.minDateTime > optionDateTime) || (options.maxTime !== false && _xdsoft_datetime.strtotime(options.maxTime).getTime() < now.getTime()) || (options.minTime !== false && _xdsoft_datetime.strtotime(options.minTime).getTime() > now.getTime())) {
                                        classes.push('xdsoft_disabled');
                                    }
        Severity: Major
        Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

          !function(a){"function"==typeof define&&define.amd?define(["jquery"],a):"object"==typeof exports?module.exports=a:a(jQuery)}(function(a){function b(b){var g=b||window.event,h=i.call(arguments,1),j=0,l=0,m=0,n=0,o=0,p=0;if(b=a.event.fix(g),b.type="mousewheel","detail"in g&&(m=-1*g.detail),"wheelDelta"in g&&(m=g.wheelDelta),"wheelDeltaY"in g&&(m=g.wheelDeltaY),"wheelDeltaX"in g&&(l=-1*g.wheelDeltaX),"axis"in g&&g.axis===g.HORIZONTAL_AXIS&&(l=-1*m,m=0),j=0===m?l:m,"deltaY"in g&&(m=-1*g.deltaY,j=m),"deltaX"in g&&(l=g.deltaX,0===m&&(j=-1*l)),0!==m||0!==l){if(1===g.deltaMode){var q=a.data(this,"mousewheel-line-height");j*=q,m*=q,l*=q}else if(2===g.deltaMode){var r=a.data(this,"mousewheel-page-height");j*=r,m*=r,l*=r}if(n=Math.max(Math.abs(m),Math.abs(l)),(!f||f>n)&&(f=n,d(g,n)&&(f/=40)),d(g,n)&&(j/=40,l/=40,m/=40),j=Math[j>=1?"floor":"ceil"](j/f),l=Math[l>=1?"floor":"ceil"](l/f),m=Math[m>=1?"floor":"ceil"](m/f),k.settings.normalizeOffset&&this.getBoundingClientRect){var s=this.getBoundingClientRect();o=b.clientX-s.left,p=b.clientY-s.top}return b.deltaX=l,b.deltaY=m,b.deltaFactor=f,b.offsetX=o,b.offsetY=p,b.deltaMode=0,h.unshift(b,j,l,m),e&&clearTimeout(e),e=setTimeout(c,200),(a.event.dispatch||a.event.handle).apply(this,h)}}function c(){f=null}function d(a,b){return k.settings.adjustOldDeltas&&"mousewheel"===a.type&&b%120===0}var e,f,g=["wheel","mousewheel","DOMMouseScroll","MozMousePixelScroll"],h="onwheel"in document||document.documentMode>=9?["wheel"]:["mousewheel","DomMouseScroll","MozMousePixelScroll"],i=Array.prototype.slice;if(a.event.fixHooks)for(var j=g.length;j;)a.event.fixHooks[g[--j]]=a.event.mouseHooks;var k=a.event.special.mousewheel={version:"3.1.12",setup:function(){if(this.addEventListener)for(var c=h.length;c;)this.addEventListener(h[--c],b,!1);else this.onmousewheel=b;a.data(this,"mousewheel-line-height",k.getLineHeight(this)),a.data(this,"mousewheel-page-height",k.getPageHeight(this))},teardown:function(){if(this.removeEventListener)for(var c=h.length;c;)this.removeEventListener(h[--c],b,!1);else this.onmousewheel=null;a.removeData(this,"mousewheel-line-height"),a.removeData(this,"mousewheel-page-height")},getLineHeight:function(b){var c=a(b),d=c["offsetParent"in a.fn?"offsetParent":"parent"]();return d.length||(d=a("body")),parseInt(d.css("fontSize"),10)||parseInt(c.css("fontSize"),10)||16},getPageHeight:function(b){return a(b).height()},settings:{adjustOldDeltas:!0,normalizeOffset:!0}};a.fn.extend({mousewheel:function(a){return a?this.bind("mousewheel",a):this.trigger("mousewheel")},unmousewheel:function(a){return this.unbind("mousewheel",a)}})});
          Severity: Major
          Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                                        if ((options.initTime || options.defaultSelect || datetimepicker.data('changed')) && current_time.getHours() === parseInt(h, 10) && (options.step > 59 || current_time.getMinutes() === parseInt(m, 10))) {
                                            if (options.defaultSelect || datetimepicker.data('changed')) {
                                                classes.push('xdsoft_current');
                                            } else if (options.initTime) {
                                                classes.push('xdsoft_init_time');
            Severity: Major
            Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

              Consider simplifying this complex logical expression.
              Open

                                          if(!options.datepicker && options.timepicker && splittedHours >= 0 && splittedHours < 24 && splittedMinutes >= 0 && splittedMinutes < 60) {
                                            $(this).val([splittedHours, splittedMinutes].map(function(item) {
                                              return item > 9 ? item : '0' + item
                                            }).join(':'));
                                          } else {
              Severity: Major
              Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

                Function upload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function upload ($f3, $params) {
                        $account = mustBeLoggedIn();
                        $dispute = setDisputeFromParams($f3, $params);
                
                        if (!$dispute->getState()->canUploadDocuments()) {
                Severity: Minor
                Found in webapp/core/controller/EvidenceController.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function requiredParams has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function requiredParams($requiredParams, $array) {
                        $filteredParams = array();
                        foreach($requiredParams as $fieldName => $required) {
                            if (!isset($array[$fieldName])) {
                                if ($required) {
                Severity: Minor
                Found in webapp/core/helpers/Utils.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function emit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function emit($event, $dispute = false, $parameters = array()) {
                        $actions = @$this->subscriptions[$event];
                        // if no modules have hooked into the event, $actions will be null
                        if ($actions) {
                            foreach ($actions as $action) {
                Severity: Minor
                Found in webapp/core/helpers/ModuleController.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function closeDisputePost has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    function closeDisputePost ($f3, $params) {
                        $account = mustBeLoggedInAsAn('Agent');
                        $dispute = setDisputeFromParams($f3, $params);
                
                        $verdict = $f3->get('POST.verdict');
                Severity: Minor
                Found in webapp/core/controller/DisputeController.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function ensureCorrectAccountTypes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function ensureCorrectAccountTypes($accountTypes) {
                        $correctAccountTypes = true;
                        if (isset($accountTypes['law_firm'])) {
                            if (!DBGet::instance()->account($accountTypes['law_firm']) instanceof LawFirm) {
                                $correctAccountTypes = false;
                Severity: Minor
                Found in webapp/core/db/DBQuery.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                                return new Admin($account);
                Severity: Major
                Found in webapp/core/db/DBGet.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return "DisputeOpened";
                  Severity: Major
                  Found in webapp/core/helpers/DisputeStateCalculator.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return "InMediation";
                    Severity: Major
                    Found in webapp/core/helpers/DisputeStateCalculator.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return "LifespanNegotiated";
                      Severity: Major
                      Found in webapp/core/helpers/DisputeStateCalculator.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return new MediationCentre($account);
                        Severity: Major
                        Found in webapp/core/db/DBGet.php - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language