ChrisBAshton/smartresolution

View on GitHub

Showing 82 of 82 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                    if (options.onChangeMonth && $.isFunction(options.onChangeMonth)) {
                        options.onChangeMonth.call(datetimepicker, _xdsoft_datetime.currentTime, datetimepicker.data('input'));
                    }
Severity: Major
Found in webapp/core/view/js/jquery.datetimepicker.js and 3 other locations - About 1 hr to fix
webapp/core/view/js/jquery.datetimepicker.js on lines 1158..1160
webapp/core/view/js/jquery.datetimepicker.js on lines 1188..1190
webapp/core/view/js/jquery.datetimepicker.js on lines 1674..1676

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                    if (options.onChangeMonth && $.isFunction(options.onChangeMonth)) {
                        options.onChangeMonth.call(datetimepicker, _xdsoft_datetime.currentTime, datetimepicker.data('input'));
                    }
Severity: Major
Found in webapp/core/view/js/jquery.datetimepicker.js and 3 other locations - About 1 hr to fix
webapp/core/view/js/jquery.datetimepicker.js on lines 814..816
webapp/core/view/js/jquery.datetimepicker.js on lines 1158..1160
webapp/core/view/js/jquery.datetimepicker.js on lines 1674..1676

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function line_time has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

                        line_time = function line_time(h, m) {
                            var now = _xdsoft_datetime.now();
                            now.setHours(h);
                            h = parseInt(now.getHours(), 10);
                            now.setMinutes(m);
Severity: Minor
Found in webapp/core/view/js/jquery.datetimepicker.js - About 1 hr to fix

    Method individualPost has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function individualPost ($f3) {
            mustBeLoggedInAsAn('Organisation');
    
            $email    = $f3->get('POST.email');
            $password = $f3->get('POST.password');
    Severity: Minor
    Found in webapp/core/controller/RegisterController.php - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

                          } else if (e.type === 'mousedown' || e.type === 'mouseup' || e.type === 'mousemove' || e.type === 'mouseover' || e.type === 'mouseout' || e.type === 'mouseenter' || e.type === 'mouseleave') {
                              out.x = e.clientX;
                              out.y = e.clientY;
                          }
      Severity: Major
      Found in webapp/core/view/js/jquery.datetimepicker.js - About 1 hr to fix

        Function accountDetails has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function accountDetails($loginID) {
                $individual    = $this->getAccountRowByLoginId('individuals',    $loginID);
                $organisation  = $this->getAccountRowByLoginId('organisations',  $loginID);
                $administrator = $this->getAccountRowByLoginId('administrators', $loginID);
                $details       = false;
        Severity: Minor
        Found in webapp/core/db/DBGet.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function invalid has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function invalid($validUntil, $startTime, $endTime) {
                $currentTime = time();
                $invalidBecause = false;
        
                if ($validUntil < $currentTime || $startTime < $currentTime || $endTime < $currentTime) {
        Severity: Minor
        Found in webapp/core/model/Lifespan.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function view has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            function view ($f3, $params) {
                $account = mustBeLoggedInAsAn('Agent');
                $dispute = setDisputeFromParams($f3, $params);
        
                if ($dispute->getLatestLifespan()->accepted()) {
        Severity: Minor
        Found in webapp/core/controller/LifespanController.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setUp has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function setUp($f3, $params) {
                $this->account = mustBeLoggedInAsAn('Individual');
                $this->dispute = setDisputeFromParams($f3, $params);
        
                if (!$this->dispute->canBeViewedBy($this->account->getLoginId())) {
        Severity: Minor
        Found in webapp/core/controller/MessageController.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setDefaultActions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function setDefaultActions($dispute, $account) {
                global $dashboardActions;
                $dashboardActions = array();
                $state = $dispute->getState($account);
        
        
        Severity: Minor
        Found in webapp/core/helpers/DisputeStateCalculator.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function evidence($params) {
                $params = Utils::instance()->requiredParams(array(
                    'dispute_id'  => true,
                    'uploader_id' => true,
                    'filepath'    => true
        Severity: Minor
        Found in webapp/core/db/DBCreate.php and 1 other location - About 55 mins to fix
        webapp/core/db/DBCreate.php on lines 85..97

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function disputeParty($params) {
                $params = Utils::instance()->requiredParams(array(
                    'organisation_id' => true,
                    'individual_id'   => false,
                    'summary'         => false
        Severity: Minor
        Found in webapp/core/db/DBCreate.php and 1 other location - About 55 mins to fix
        webapp/core/db/DBCreate.php on lines 107..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid deeply nested control flow statements.
        Open

                                            if (pos === options.mask.length) {
                                                event.preventDefault();
                                                return false;
                                            }
        Severity: Major
        Found in webapp/core/view/js/jquery.datetimepicker.js - About 45 mins to fix

          Consider simplifying this complex logical expression.
          Open

                  if (!$title || !$agent || !$type  || !$summary || $agent === '---' || $type === '---') {
                      $f3->set('error_message', 'Please fill in all fields.');
                  }
                  else {
                      try {
          Severity: Major
          Found in webapp/core/controller/DisputeController.php - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                                        if ((maxDate !== false && start > maxDate) || (minDate !== false && start < minDate) || (customDateSettings && customDateSettings[0] === false)) {
                                            classes.push('xdsoft_disabled');
                                        } else if (options.disabledDates.indexOf(start.dateFormat(options.formatDate)) !== -1) {
                                            classes.push('xdsoft_disabled');
                                        }
            Severity: Major
            Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

              Consider simplifying this complex logical expression.
              Open

                                          if((options.minDateTime !== false && options.minDateTime > optionDateTime) || (options.maxTime !== false && _xdsoft_datetime.strtotime(options.maxTime).getTime() < now.getTime()) || (options.minTime !== false && _xdsoft_datetime.strtotime(options.minTime).getTime() > now.getTime())) {
                                              classes.push('xdsoft_disabled');
                                          }
              Severity: Major
              Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

                Consider simplifying this complex logical expression.
                Open

                !function(a){"function"==typeof define&&define.amd?define(["jquery"],a):"object"==typeof exports?module.exports=a:a(jQuery)}(function(a){function b(b){var g=b||window.event,h=i.call(arguments,1),j=0,l=0,m=0,n=0,o=0,p=0;if(b=a.event.fix(g),b.type="mousewheel","detail"in g&&(m=-1*g.detail),"wheelDelta"in g&&(m=g.wheelDelta),"wheelDeltaY"in g&&(m=g.wheelDeltaY),"wheelDeltaX"in g&&(l=-1*g.wheelDeltaX),"axis"in g&&g.axis===g.HORIZONTAL_AXIS&&(l=-1*m,m=0),j=0===m?l:m,"deltaY"in g&&(m=-1*g.deltaY,j=m),"deltaX"in g&&(l=g.deltaX,0===m&&(j=-1*l)),0!==m||0!==l){if(1===g.deltaMode){var q=a.data(this,"mousewheel-line-height");j*=q,m*=q,l*=q}else if(2===g.deltaMode){var r=a.data(this,"mousewheel-page-height");j*=r,m*=r,l*=r}if(n=Math.max(Math.abs(m),Math.abs(l)),(!f||f>n)&&(f=n,d(g,n)&&(f/=40)),d(g,n)&&(j/=40,l/=40,m/=40),j=Math[j>=1?"floor":"ceil"](j/f),l=Math[l>=1?"floor":"ceil"](l/f),m=Math[m>=1?"floor":"ceil"](m/f),k.settings.normalizeOffset&&this.getBoundingClientRect){var s=this.getBoundingClientRect();o=b.clientX-s.left,p=b.clientY-s.top}return b.deltaX=l,b.deltaY=m,b.deltaFactor=f,b.offsetX=o,b.offsetY=p,b.deltaMode=0,h.unshift(b,j,l,m),e&&clearTimeout(e),e=setTimeout(c,200),(a.event.dispatch||a.event.handle).apply(this,h)}}function c(){f=null}function d(a,b){return k.settings.adjustOldDeltas&&"mousewheel"===a.type&&b%120===0}var e,f,g=["wheel","mousewheel","DOMMouseScroll","MozMousePixelScroll"],h="onwheel"in document||document.documentMode>=9?["wheel"]:["mousewheel","DomMouseScroll","MozMousePixelScroll"],i=Array.prototype.slice;if(a.event.fixHooks)for(var j=g.length;j;)a.event.fixHooks[g[--j]]=a.event.mouseHooks;var k=a.event.special.mousewheel={version:"3.1.12",setup:function(){if(this.addEventListener)for(var c=h.length;c;)this.addEventListener(h[--c],b,!1);else this.onmousewheel=b;a.data(this,"mousewheel-line-height",k.getLineHeight(this)),a.data(this,"mousewheel-page-height",k.getPageHeight(this))},teardown:function(){if(this.removeEventListener)for(var c=h.length;c;)this.removeEventListener(h[--c],b,!1);else this.onmousewheel=null;a.removeData(this,"mousewheel-line-height"),a.removeData(this,"mousewheel-page-height")},getLineHeight:function(b){var c=a(b),d=c["offsetParent"in a.fn?"offsetParent":"parent"]();return d.length||(d=a("body")),parseInt(d.css("fontSize"),10)||parseInt(c.css("fontSize"),10)||16},getPageHeight:function(b){return a(b).height()},settings:{adjustOldDeltas:!0,normalizeOffset:!0}};a.fn.extend({mousewheel:function(a){return a?this.bind("mousewheel",a):this.trigger("mousewheel")},unmousewheel:function(a){return this.unbind("mousewheel",a)}})});
                Severity: Major
                Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

                  Consider simplifying this complex logical expression.
                  Open

                                              if ((options.initTime || options.defaultSelect || datetimepicker.data('changed')) && current_time.getHours() === parseInt(h, 10) && (options.step > 59 || current_time.getMinutes() === parseInt(m, 10))) {
                                                  if (options.defaultSelect || datetimepicker.data('changed')) {
                                                      classes.push('xdsoft_current');
                                                  } else if (options.initTime) {
                                                      classes.push('xdsoft_init_time');
                  Severity: Major
                  Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

                    Consider simplifying this complex logical expression.
                    Open

                                                if(!options.datepicker && options.timepicker && splittedHours >= 0 && splittedHours < 24 && splittedMinutes >= 0 && splittedMinutes < 60) {
                                                  $(this).val([splittedHours, splittedMinutes].map(function(item) {
                                                    return item > 9 ? item : '0' + item
                                                  }).join(':'));
                                                } else {
                    Severity: Major
                    Found in webapp/core/view/js/jquery.datetimepicker.js - About 40 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                                  var splittedHours   = +([$(this).val()[0], $(this).val()[1]].join('')),
                      Severity: Minor
                      Found in webapp/core/view/js/jquery.datetimepicker.js and 1 other location - About 40 mins to fix
                      webapp/core/view/js/jquery.datetimepicker.js on lines 1027..1027

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language