ChrisBAshton/smartresolution

View on GitHub
webapp/core/helpers/DisputeStateCalculator.php

Summary

Maintainability
C
1 day
Test Coverage

Method setDefaultActions has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function setDefaultActions($dispute, $account) {
        global $dashboardActions;
        $dashboardActions = array();
        $state = $dispute->getState($account);

Severity: Major
Found in webapp/core/helpers/DisputeStateCalculator.php - About 2 hrs to fix

    Function calculateStateClass has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function calculateStateClass($dispute) {
            if ($dispute->getStatus() !== 'ongoing') {
                return "DisputeClosed";
            }
    
    
    Severity: Minor
    Found in webapp/core/helpers/DisputeStateCalculator.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method calculateStateClass has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function calculateStateClass($dispute) {
            if ($dispute->getStatus() !== 'ongoing') {
                return "DisputeClosed";
            }
    
    
    Severity: Minor
    Found in webapp/core/helpers/DisputeStateCalculator.php - About 1 hr to fix

      Function setDefaultActions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setDefaultActions($dispute, $account) {
              global $dashboardActions;
              $dashboardActions = array();
              $state = $dispute->getState($account);
      
      
      Severity: Minor
      Found in webapp/core/helpers/DisputeStateCalculator.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return "DisputeOpened";
      Severity: Major
      Found in webapp/core/helpers/DisputeStateCalculator.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return "InMediation";
        Severity: Major
        Found in webapp/core/helpers/DisputeStateCalculator.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return "LifespanNegotiated";
          Severity: Major
          Found in webapp/core/helpers/DisputeStateCalculator.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return "InRoundTableMediation";
            Severity: Major
            Found in webapp/core/helpers/DisputeStateCalculator.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status