# CiscoUcs/ucsmsdk

ucsmsdk/utils/ucskvmlaunch.py

### Summary

D
2 days

#### Function `ucs_kvm_launch` has a Cognitive Complexity of 76 (exceeds 5 allowed). Consider refactoring. Open

``````def ucs_kvm_launch(handle, service_profile=None, blade=None, rack_unit=None,
frame_title=None, need_url=False):
"""
ucs_kvm_launch launches the kvm session for a specified server.

``````
Found in ucsmsdk/utils/ucskvmlaunch.py - About 1 day to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Cyclomatic complexity is too high in function ucs_kvm_launch. (45) Open

``````def ucs_kvm_launch(handle, service_profile=None, blade=None, rack_unit=None,
frame_title=None, need_url=False):
"""
ucs_kvm_launch launches the kvm session for a specified server.

``````

## Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

#### Function `ucs_kvm_launch` has 6 arguments (exceeds 4 allowed). Consider refactoring. Open

``def ucs_kvm_launch(handle, service_profile=None, blade=None, rack_unit=None,``
Found in ucsmsdk/utils/ucskvmlaunch.py - About 45 mins to fix

#### Consider simplifying this complex logical expression. Open

``````    if (blade is not None and rack_unit is not None) or \
(service_profile is not None and rack_unit is not None) or \
(blade is not None and service_profile is not None):
raise UcsValidationException(
"Provide only one parameter from blade, "``````
Found in ucsmsdk/utils/ucskvmlaunch.py - About 40 mins to fix

#### Refactor this function to reduce its Cognitive Complexity from 79 to the 15 allowed. Open

``def ucs_kvm_launch(handle, service_profile=None, blade=None, rack_unit=None,``
Found in ucsmsdk/utils/ucskvmlaunch.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

## See

#### Remove this commented out code. Open

``        # sp_mo = service_profile``
Found in ucsmsdk/utils/ucskvmlaunch.py by sonar-python

Programmers should not comment out code as it bloats programs and reduces readability.

Unused code should be deleted and can be retrieved from source control history if required.

## See

• MISRA C:2004, 2.4 - Sections of code should not be "commented out".
• MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
• MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
• MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

#### Remove this commented out code. Open

``    # lock = Lock()``
Found in ucsmsdk/utils/ucskvmlaunch.py by sonar-python

Programmers should not comment out code as it bloats programs and reduces readability.

Unused code should be deleted and can be retrieved from source control history if required.

## See

• MISRA C:2004, 2.4 - Sections of code should not be "commented out".
• MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
• MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
• MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

#### TODO found Open

``        # TODO:replace class_id with proper constantafter generating mos.py``
Found in ucsmsdk/utils/ucskvmlaunch.py by fixme

#### Identical blocks of code found in 2 locations. Consider refactoring. Open

``````        if response.error_code == 0:
for mgmt_if in response.out_configs.child:
if mgmt_if.subject == MgmtIfConsts.SUBJECT_BLADE and \
Found in ucsmsdk/utils/ucskvmlaunch.py and 1 other location - About 1 hr to fix
ucsmsdk/utils/ucskvmlaunch.py on lines 189..193

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Identical blocks of code found in 2 locations. Consider refactoring. Open

``````        if response.error_code == 0:
for mgmt_if in response.out_configs.child:
if mgmt_if.subject == MgmtIfConsts.SUBJECT_BLADE and \
Found in ucsmsdk/utils/ucskvmlaunch.py and 1 other location - About 1 hr to fix
ucsmsdk/utils/ucskvmlaunch.py on lines 122..126

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Similar blocks of code found in 2 locations. Consider refactoring. Open

``````        if frame_title is None:
frame_title = handle.name + ':' + pn_dn + ' KVM Console'``````
Found in ucsmsdk/utils/ucskvmlaunch.py and 1 other location - About 45 mins to fix
ucsmsdk/utils/ucskvmlaunch.py on lines 141..142

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Similar blocks of code found in 2 locations. Consider refactoring. Open

``````            if frame_title is None:
frame_title = handle.name + ':' + dn + ' KVM Console'``````
Found in ucsmsdk/utils/ucskvmlaunch.py and 1 other location - About 45 mins to fix
ucsmsdk/utils/ucskvmlaunch.py on lines 109..110

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Identical blocks of code found in 2 locations. Consider refactoring. Open

``````        elem = config_scope(cookie=handle.cookie,
dn=pn_dn,
in_class=NamingId.MGMT_IF,
in_filter=None,
in_recursive=YesOrNo.FALSE,``````
Found in ucsmsdk/utils/ucskvmlaunch.py and 1 other location - About 40 mins to fix
ucsmsdk/utils/ucskvmlaunch.py on lines 114..119

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Identical blocks of code found in 2 locations. Consider refactoring. Open

``````        elem = config_scope(cookie=handle.cookie,
dn=pn_dn,
in_class=NamingId.MGMT_IF,
in_filter=None,
in_recursive=YesOrNo.FALSE,``````
Found in ucsmsdk/utils/ucskvmlaunch.py and 1 other location - About 40 mins to fix
ucsmsdk/utils/ucskvmlaunch.py on lines 181..186

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.