Sign upLogin

CycloneTechnology/ChaMP

View on GitHub
Star

Showing 19 of 19 total issues

Constructor has 22 arguments (exceeds 10 allowed). Consider refactoring.
Open

  sensorId: SensorId,
  ownerId: SensorOwnerId,
  ownerLun: SensorOwnerLun,
  sensorNumber: SensorNumber,
  entityId: EntityId,
Severity: Major
Found in champ-ipmi/src/main/scala/com/cyclone/ipmi/protocol/sdr/FullSdrKeyAndBody.scala - About 2 hrs to fix

    Function resolveReferences has 65 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

        ): Future[WSManErrorOr[ManagedInstance]] = {

      val lookupRef: ManagedReference => Future[WSManErrorOr[ManagedInstance]] =
        Memo.immutableHashMapMemo { mr =>
          referenceResolver.get(mr, deadline)(ctx)
    Severity: Major
    Found in champ-wsman/src/main/scala/com/cyclone/wsman/WSManOperationContext.scala - About 1 hr to fix

      Function parseFullyQualifiedUser has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def parseFullyQualifiedUser(
    fullyQualifiedUsername: String,
    password: String
  ): PasswordCredentials = {
    val (user, optDomain) = {
      Severity: Minor
      Found in champ-core/src/main/scala/com/cyclone/util/PasswordCredentials.scala - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function kerberosCore has 60 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

        private def kerberosCore(clientToken: Array[Byte]): Either[Rejection, Token] = {
    try {
      val (maybeServerToken, maybeToken) =
        Subject.doAs(
          loginContext.getSubject,
      Severity: Major
      Found in champ-core/src/main/scala/com/cyclone/util/spnego/SpnegoAuthenticator.scala - About 1 hr to fix

        Constructor has 15 arguments (exceeds 10 allowed). Consider refactoring.
        Open

          baseSensorId: SensorId,
  ownerId: SensorOwnerId,
  ownerLun: SensorOwnerLun,
  baseSensorNumber: SensorNumber,
  entityId: EntityId,
        Severity: Major
        Found in champ-ipmi/src/main/scala/com/cyclone/ipmi/protocol/sdr/CompactSdrKeyAndBody.scala - About 1 hr to fix

          Constructor has 14 arguments (exceeds 10 allowed). Consider refactoring.
          Open

              guid: Option[Guid.Data],
    assetTag: Option[ShortString],
    serviceTag: Option[ShortString],
    chassisServiceTag: Option[ShortString],
    chassisRelatedServiceTag: Option[ShortString],
          Severity: Major
          Found in champ-ipmi/src/main/scala/com/cyclone/ipmi/tool/command/oem/dell/SystemInfoTool.scala - About 1 hr to fix

            Constructor has 12 arguments (exceeds 10 allowed). Consider refactoring.
            Open

              deviceAccessAddress: DeviceAddress,
  channelNumber: ChannelNumber,
  acpiSystemPowerStateNotificationRequired: Boolean,
  acpiDevicePowerStateNotificationRequired: Boolean,
  controllerShouldBePresent: Boolean,
            Severity: Major
            Found in champ-ipmi/src/main/scala/com/cyclone/ipmi/protocol/sdr/McDeviceLocatorRecordKeyAndBody.scala - About 45 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                object CommandResult {
    implicit val decoder: Decoder[CommandResult] = new Decoder[CommandResult] {

      def decode(data: ByteString): CommandResult = {
//        val iterator = data.iterator
              Severity: Minor
              Found in champ-ipmi/src/main/scala/com/cyclone/ipmi/command/oem/fujitsu/s2s3/GetEepromVersionInfo.scala and 1 other location - About 40 mins to fix
              champ-ipmi/src/main/scala/com/cyclone/ipmi/command/oem/fujitsu/s4/GetEepromVersionInfo.scala on lines 68..103

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                object CommandResult extends IpmiCommandResult {
    implicit val decoder: Decoder[CommandResult] = new Decoder[CommandResult] {

      def decode(data: ByteString): CommandResult = {
//        val iterator = data.iterator
              Severity: Minor
              Found in champ-ipmi/src/main/scala/com/cyclone/ipmi/command/oem/fujitsu/s4/GetEepromVersionInfo.scala and 1 other location - About 40 mins to fix
              champ-ipmi/src/main/scala/com/cyclone/ipmi/command/oem/fujitsu/s2s3/GetEepromVersionInfo.scala on lines 68..103

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Constructor has 11 arguments (exceeds 10 allowed). Consider refactoring.
              Open

                  cpuId: Short,
    platformId: Byte,
    brandId: Byte,
    maximalCoreSpeedOfCpuMHz: Short,
    intelQuickpathInterconnectMegaTransactionsPerSecond: Short,
              Severity: Major
              Found in champ-ipmi/src/main/scala/com/cyclone/ipmi/command/oem/fujitsu/common/firmware/GetCpuInfo.scala - About 35 mins to fix

                Function sequentiallyUntilSuccess has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  def sequentiallyUntilSuccess[T](
    tasks: Seq[() => Future[T]]
  )(implicit executor: ExecutionContext): Future[T] = {

    if (tasks.isEmpty)
                Severity: Minor
                Found in champ-core/src/main/scala/com/cyclone/util/concurrent/Futures.scala - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function handle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    override def handle(callbacks: Array[Callback]): Unit = {
      val credentials = tlCredentials.get

      if (credentials != null) {
        for (callback <- callbacks) {
                Severity: Minor
                Found in champ-wsman/src/main/scala/com/cyclone/wsman/impl/http/WSManConnection.scala - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        inside(wsman.executeCommandOrError(target, query).futureValue) {
          case \/-(result) =>
            result.filterFor(ShellOutputStream.STDOUT) should include(file.getName)
        }
                Severity: Minor
                Found in champ-wsman/src/it/scala/com/cyclone/wsman/WSManTest.scala and 1 other location - About 30 mins to fix
                champ-wsman/src/it/scala/com/cyclone/wsman/WSManTest.scala on lines 578..581

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        inside(wsman.executeCommandOrError(target, query).futureValue) {
          case \/-(result) =>
            result.filterFor(ShellOutputStream.STDOUT) should include(file.getName)
        }
                Severity: Minor
                Found in champ-wsman/src/it/scala/com/cyclone/wsman/WSManTest.scala and 1 other location - About 30 mins to fix
                champ-wsman/src/it/scala/com/cyclone/wsman/WSManTest.scala on lines 543..546

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function validateRakp2Response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    private def validateRakp2Response(
      rakp1: Rakp1_2.Command,
      rakp2Result: Rakp1_2.CommandResult,
      cipherSuite: CipherSuite
    ): StatusCodeErrorOr[Unit] = {
                Severity: Minor
                Found in champ-ipmi/src/main/scala/com/cyclone/ipmi/protocol/SessionNegotiationProtocol.scala - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Anonymous function has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    val (user, optDomain) = {
      val atIdx = fullyQualifiedUsername.indexOf('@')

      if (atIdx >= 0) {
        val (u, d) = fullyQualifiedUsername.splitAt(atIdx)
                Severity: Minor
                Found in champ-core/src/main/scala/com/cyclone/util/PasswordCredentials.scala - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function validateRakp4Response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    private def validateRakp4Response(
      rakp1: Rakp1_2.Command,
      rakp2Result: Rakp1_2.CommandResult,
      rakp4Result: Rakp3_4.CommandResult,
      cipherSuite: CipherSuite,
                Severity: Minor
                Found in champ-ipmi/src/main/scala/com/cyclone/ipmi/protocol/SessionNegotiationProtocol.scala - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  private def add(
    inst: ManagedInstance,
    list: ListBuffer[(String, String)],
    prefix: String,
    propertyRestriction: PropertyRestriction = PropertyRestriction.NoRestriction
                Severity: Minor
                Found in champ-wsman/src/main/scala/com/cyclone/wsman/WSManOperationContext.scala - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function parseInt has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def parseInt(value: String): Option[Int] = {
    if (value == null)
      None
    else {
      val parse: Integer = Ints.tryParse(value)
                Severity: Minor
                Found in champ-core/src/main/scala/com/cyclone/util/NumberUtils.scala - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language