DaoCasino/bankroller-core

View on GitHub

Showing 15 of 397 total issues

Function channelState has a Cognitive Complexity of 36 (exceeds 15 allowed). Consider refactoring.
Open

const channelState = function (player_openkey = false) {
  if (!player_openkey) {
    console.error(' player_openkey required in channelState constructor')
    return
  }
Severity: Minor
Found in lib/dapps/DApp.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File DApp.js has 546 lines of code (exceeds 500 allowed). Consider refactoring.
Open

import _config         from 'config'
import path            from 'path'
import * as messaging  from 'dc-messaging'
import PQueue          from 'p-queue'
import Eth             from 'Eth'
Severity: Major
Found in lib/dapps/DApp.js - About 3 hrs to fix

    Function _call has a Cognitive Complexity of 27 (exceeds 15 allowed). Consider refactoring.
    Open

      async _call (data) {
        const user = this.users[data.user_id]
        if (!data.data || !data.data.gamedata || !data.data.seed) return
        if (!data.func || !data.func.name || !data.func.args) return
    
    
    Severity: Minor
    Found in lib/dapps/DApp.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _call has 120 lines of code (exceeds 100 allowed). Consider refactoring.
    Open

      async _call (data) {
        const user = this.users[data.user_id]
        if (!data.data || !data.data.gamedata || !data.data.seed) return
        if (!data.func || !data.func.name || !data.func.args) return
    
    
    Severity: Major
    Found in lib/dapps/DApp.js - About 1 hr to fix

      Function _newUser has a Cognitive Complexity of 21 (exceeds 15 allowed). Consider refactoring.
      Open

        async _newUser (params) {
          const connection_id = Utils.makeSeed()
          const user_id       = params.user_id
      
          if (this.users[user_id]) delete this.users[user_id]
      Severity: Minor
      Found in lib/dapps/DApp.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function channelState has 104 lines of code (exceeds 100 allowed). Consider refactoring.
      Open

      const channelState = function (player_openkey = false) {
        if (!player_openkey) {
          console.error(' player_openkey required in channelState constructor')
          return
        }
      Severity: Major
      Found in lib/dapps/DApp.js - About 1 hr to fix

        Function loadDApp has a Cognitive Complexity of 18 (exceeds 15 allowed). Consider refactoring.
        Open

          loadDApp (key) {
            const readManifest = function (file_path) {
              const tryReadFile = (path) => {
                try {
                  let dapp_config = JSON.parse(fs.readFileSync(path))
        Severity: Minor
        Found in lib/dapps/dapps.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

              return
        Severity: Major
        Found in lib/dapps/DApp.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (!confirmed) return
          Severity: Major
          Found in lib/dapps/DApp.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return true
            Severity: Major
            Found in lib/dapps/DApp.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return false
              Severity: Major
              Found in lib/dapps/DApp.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return
                Severity: Major
                Found in lib/dapps/DApp.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return
                  Severity: Major
                  Found in lib/dapps/DApp.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return false
                    Severity: Major
                    Found in lib/dapps/DApp.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return
                      Severity: Major
                      Found in lib/dapps/DApp.js - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language