DeveloperCAP/MLCAT

View on GitHub
lib/analysis/author/edge_list.py

Summary

Maintainability
C
1 day
Test Coverage

Function generate_edge_list has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

def generate_edge_list(author_nodes, author_edges, graph_nodes,
                       graph_edges, threads_json, author_json, ignore_lat=True):
    """    
    :param author_nodes: The csv file containing the author nodes data.
    :param author_edges: The csv file containing the author edges data.
Severity: Minor
Found in lib/analysis/author/edge_list.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generate_edge_list has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def generate_edge_list(author_nodes, author_edges, graph_nodes,
Severity: Major
Found in lib/analysis/author/edge_list.py - About 50 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if json_obj['Time'] < time_limit:
                            # print("\nFrom", json_obj['From'], "\nTo", json_obj['To'], "\nCc", json_obj['Cc'])
                            from_addr = email_re.search(json_obj['From'])
                            json_obj['From'] = from_addr.group(0) if from_addr is not None else json_obj['From']
                            json_obj['To'] = set(email_re.findall(json_obj['To']))
    Severity: Major
    Found in lib/analysis/author/edge_list.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status