Sign upLogin

DeveloperCAP/MLCAT

View on GitHub
Star
lib/analysis/author/ranking.py

Summary

Maintainability
C
1 day
Test Coverage

Function get has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
Open

def get(json_filename, output_filename, active_score, passive_score, write_to_file=True):
    """

    :param json_data: The JSON file containing the headers.
    :param output_filename: Stores authors' email address,score and rank.
Severity: Minor
Found in lib/analysis/author/ranking.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if time_lbound <= json_obj['Time'] < time_ubound:
                        # print("\nFrom", json_obj['From'], "\nTo", json_obj['To'], "\nCc", json_obj['Cc'])
                        from_addr = email_re.search(json_obj['From'])
                        json_obj['From'] = from_addr.group(0) if from_addr is not None else json_obj['From']
                        json_obj['To'] = set(email_re.findall(json_obj['To']))
Severity: Major
Found in lib/analysis/author/ranking.py - About 45 mins to fix

    Function get has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def get(json_filename, output_filename, active_score, passive_score, write_to_file=True):
    Severity: Minor
    Found in lib/analysis/author/ranking.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status