Sign upLogin

DeveloperCAP/MLCAT

View on GitHub
Star
lib/analysis/thread/graph/generate.py

Summary

Maintainability
C
1 day
Test Coverage

Function digraph has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

def digraph():
    """
    This function is used to generate a thread-wise view of the entire mailing list by saving the a graph representing the
    messages in a thread as a tree using the References and In-Reply-TO fields from the mail headers. The thread graphs are
    then saved to GEXF, DOT and PNG formats. All authors of a thread are identified and each author is given a unique color.
Severity: Minor
Found in lib/analysis/thread/graph/generate.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    with open("graph_edges.csv", "r") as edge_file:
        for pair in edge_file:
            edge = pair.split(';')
            edge[1] = edge[1].strip()
            try:
Severity: Major
Found in lib/analysis/thread/graph/generate.py and 1 other location - About 7 hrs to fix
lib/analysis/thread/hypergraph.py on lines 93..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status