Sign upLogin

DigitalState/Platform-Notification-Bundle

View on GitHub
Star

Showing 15 of 17 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    protected function addNotificationPresentationForeignKeys(Schema $schema)
    {
        $table = $schema->getTable('ds_notif_presentation');
        $table->addForeignKeyConstraint(
            $schema->getTable('oro_fallback_localization_val'),
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 5 other locations - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 160..175
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 182..197
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 204..219
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 248..263
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 304..319

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    protected function addNotificationChannelForeignKeys(Schema $schema)
    {
        $table = $schema->getTable('ds_notif_channel');
        $table->addForeignKeyConstraint(
            $schema->getTable('ds_comm_channel'),
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 5 other locations - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 160..175
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 204..219
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 226..241
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 248..263
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 304..319

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    protected function addNotificationSubscriptionChannelForeignKeys(Schema $schema)
    {
        $table = $schema->getTable('ds_notif_subscription_channel');
        $table->addForeignKeyConstraint(
            $schema->getTable('ds_comm_channel'),
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 5 other locations - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 160..175
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 182..197
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 204..219
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 226..241
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 248..263

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    protected function addNotificationForeignKeys(Schema $schema)
    {
        $table = $schema->getTable('ds_notif');
        $table->addForeignKeyConstraint(
            $schema->getTable('oro_organization'),
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 5 other locations - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 182..197
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 204..219
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 226..241
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 248..263
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 304..319

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    protected function addNotificationTitleForeignKeys(Schema $schema)
    {
        $table = $schema->getTable('ds_notif_title');
        $table->addForeignKeyConstraint(
            $schema->getTable('oro_fallback_localization_val'),
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 5 other locations - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 160..175
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 182..197
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 204..219
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 226..241
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 304..319

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    protected function addNotificationDescriptionForeignKeys(Schema $schema)
    {
        $table = $schema->getTable('ds_notif_description');
        $table->addForeignKeyConstraint(
            $schema->getTable('oro_fallback_localization_val'),
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 5 other locations - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 160..175
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 182..197
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 226..241
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 248..263
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 304..319

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function createNotificationChannelTable(Schema $schema)
    {
        $table = $schema->createTable('ds_notif_channel');
        $table->addColumn('notification_id', 'integer', []);
        $table->addColumn('channel_id', 'integer', []);
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 1 other location - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 145..153

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function createNotificationSubscriptionChannelTable(Schema $schema)
    {
        $table = $schema->createTable('ds_notif_subscription_channel');
        $table->addColumn('subscription_id', 'integer', []);
        $table->addColumn('channel_id', 'integer', []);
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 1 other location - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 62..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function createNotificationTitleTable(Schema $schema)
    {
        $table = $schema->createTable('ds_notif_title');
        $table->addColumn('notification_id', 'integer', []);
        $table->addColumn('localized_value_id', 'integer', []);
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 2 other locations - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 77..85
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 92..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function createNotificationPresentationTable(Schema $schema)
    {
        $table = $schema->createTable('ds_notif_presentation');
        $table->addColumn('notification_id', 'integer', []);
        $table->addColumn('localized_value_id', 'integer', []);
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 2 other locations - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 77..85
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 107..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function createNotificationDescriptionTable(Schema $schema)
    {
        $table = $schema->createTable('ds_notif_description');
        $table->addColumn('notification_id', 'integer', []);
        $table->addColumn('localized_value_id', 'integer', []);
Severity: Major
Found in Migrations/Schema/v0_1_0/DsNotificationBundle.php and 2 other locations - About 1 hr to fix
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 92..100
Migrations/Schema/v0_1_0/DsNotificationBundle.php on lines 107..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Ds\Bundle\NotificationBundle\Controller;

use Ds\Bundle\AdminBundle\Controller\BreadController;
Severity: Minor
Found in Controller/NotificationController.php and 1 other location - About 40 mins to fix
Controller/SubscriptionController.php on lines 1..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Ds\Bundle\NotificationBundle\Controller;

use Ds\Bundle\AdminBundle\Controller\BreadController;
Severity: Minor
Found in Controller/SubscriptionController.php and 1 other location - About 40 mins to fix
Controller/NotificationController.php on lines 1..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function cgetAction()
    {
        $request = $this->get('request');
        $page = (integer) $request->get('page', 1);
        $limit = (integer) $request->get('limit', self::ITEMS_PER_PAGE);
Severity: Minor
Found in Controller/Api/Rest/NotificationController.php and 1 other location - About 30 mins to fix
Controller/Api/Rest/SubscriptionController.php on lines 30..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function cgetAction()
    {
        $request = $this->get('request');
        $page = (integer) $request->get('page', 1);
        $limit = (integer) $request->get('limit', self::ITEMS_PER_PAGE);
Severity: Minor
Found in Controller/Api/Rest/SubscriptionController.php and 1 other location - About 30 mins to fix
Controller/Api/Rest/NotificationController.php on lines 28..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language