Sign upLogin

DivisionBy-Zero/erpa-sweng

View on GitHub
Star

Showing 9 of 57 total issues

File operations.py has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from contextlib import contextmanager
from typing import Dict, List, Optional, Set
import base64

from datetime import datetime
Severity: Minor
Found in server/operations.py - About 3 hrs to fix

    Operations has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Operations:
    def __init__(self, session_broker: SessionBroker = None):
        self.session_broker = session_broker
        if not self.session_broker:
            self.session_broker = SessionBroker()
    Severity: Minor
    Found in server/operations.py - About 2 hrs to fix

      Function update_game_join_request has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Confirmed

          def update_game_join_request(self, game_uuid: str, user: User,
                                 updated_request: PlayerJoinGameRequest,
                                 session: Session) -> PlayerJoinGameRequest:
        def joined_user_leaving_game(old_request: PlayerJoinGameRequest,
                                     new_request: PlayerJoinGameRequest):
      Severity: Minor
      Found in server/operations.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method onMeasure has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
    protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
        assert (MeasureSpec.getMode(widthMeasureSpec) != MeasureSpec.UNSPECIFIED);

        final int width = MeasureSpec.getSize(widthMeasureSpec) - getPaddingLeft() - getPaddingRight();
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sweng/erpa/views/FlowLayout.java - About 1 hr to fix

        Method onMeasure has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            @Override
    protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
        assert (MeasureSpec.getMode(widthMeasureSpec) != MeasureSpec.UNSPECIFIED);

        final int width = MeasureSpec.getSize(widthMeasureSpec) - getPaddingLeft() - getPaddingRight();
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sweng/erpa/views/FlowLayout.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @Test
    public void test0PlayerCreatePopUp() {
        onView(ViewMatchers.withId(R.id.min_num_player_field)).perform(typeText("0")).perform(
            closeSoftKeyboard());
        onView(ViewMatchers.withId(R.id.max_num_player_field)).perform(typeText("3")).perform(
        Severity: Major
        Found in app/src/androidTest/java/ch/epfl/sweng/erpa/activities/CreateGameActivityTest.java and 1 other location - About 1 hr to fix
        app/src/androidTest/java/ch/epfl/sweng/erpa/activities/CreateGameActivityTest.java on lines 179..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 91.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @Test
    public void testCreatePopUpIfMaxSmallerThanMin() {
        onView(ViewMatchers.withId(R.id.min_num_player_field)).perform(typeText("3")).perform(
            closeSoftKeyboard());
        onView(ViewMatchers.withId(R.id.max_num_player_field)).perform(typeText("2")).perform(
        Severity: Major
        Found in app/src/androidTest/java/ch/epfl/sweng/erpa/activities/CreateGameActivityTest.java and 1 other location - About 1 hr to fix
        app/src/androidTest/java/ch/epfl/sweng/erpa/activities/CreateGameActivityTest.java on lines 190..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 91.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method onResume has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
    protected void onResume() {
        super.onResume();
        if (dependenciesNotReady()) return;
        asyncFetchThreads = new HashMap<>();
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sweng/erpa/activities/GameListActivity.java - About 1 hr to fix

          Function join_game has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def join_game(self, game_uuid: str, user: User, session: Session
                  ) -> PlayerJoinGameRequest:
        if user.uuid == self.get_game(game_uuid).gm_user_uuid:
            raise ValueError("The GM can't join it's own game!")
        game_participants = (session.query(PlayerJoinGameRequest)
          Severity: Minor
          Found in server/operations.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language