Draiken/opinio

View on GitHub

Showing 16 of 16 total issues

Function prototype has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

Searcher.prototype = new function() {
  // search is performed in chunks of 1000 for non-blocking user input
  var CHUNK_SIZE = 1000;
  // do not try to find more than 100 results
  var MAX_RESULTS = 100;
Severity: Minor
Found in rdoc/js/searcher.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prototype has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Searcher.prototype = new function() {
  // search is performed in chunks of 1000 for non-blocking user input
  var CHUNK_SIZE = 1000;
  // do not try to find more than 100 results
  var MAX_RESULTS = 100;
Severity: Major
Found in rdoc/js/searcher.js - About 6 hrs to fix

    Function prototype has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    Search.prototype = $.extend({}, Navigation, new function() {
      var suid = 1;
    
      this.init = function() {
        var _this = this;
    Severity: Minor
    Found in rdoc/js/search.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        for (var i=0, l = regexps.length; i < l; i++) {
          result.title = result.title.replace(regexps[i], highlighters[i]);
          result.namespace = result.namespace.replace(regexps[i], highlighters[i]);
        };
    Severity: Major
    Found in rdoc/js/searcher.js and 1 other location - About 3 hrs to fix
    rdoc/js/searcher.js on lines 161..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        for (var i=1, l = regexps.length; i < l; i++) {
          result.title = result.title.replace(regexps[i], highlighters[i]);
          result.namespace = result.namespace.replace(regexps[i], highlighters[i]);
        };
    Severity: Major
    Found in rdoc/js/searcher.js and 1 other location - About 3 hrs to fix
    rdoc/js/searcher.js on lines 139..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function prototype has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Search.prototype = $.extend({}, Navigation, new function() {
      var suid = 1;
    
      this.init = function() {
        var _this = this;
    Severity: Major
    Found in rdoc/js/search.js - About 2 hrs to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          for (var i=1, l = regexps.length; i < l; i++) {
            if (!index.match(regexps[i]) && !longIndex.match(regexps[i]))
              return false;
          };
      Severity: Major
      Found in rdoc/js/searcher.js and 2 other locations - About 1 hr to fix
      rdoc/js/searcher.js on lines 89..92
      rdoc/js/searcher.js on lines 115..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          for (var i=1, l = regexps.length; i < l; i++) {
            if (!index.match(regexps[i]) && !longIndex.match(regexps[i]))
              return false;
          };
      Severity: Major
      Found in rdoc/js/searcher.js and 2 other locations - About 1 hr to fix
      rdoc/js/searcher.js on lines 89..92
      rdoc/js/searcher.js on lines 128..131

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          for (var i=1, l = regexps.length; i < l; i++) {
            if (!index.match(regexps[i]) && !longIndex.match(regexps[i]))
              return false;
          };
      Severity: Major
      Found in rdoc/js/searcher.js and 2 other locations - About 1 hr to fix
      rdoc/js/searcher.js on lines 115..118
      rdoc/js/searcher.js on lines 128..131

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function performSearch has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function performSearch(data, regexps, queries, highlighters, state) {
          var searchIndex = data.searchIndex;
          var longSearchIndex = data.longSearchIndex;
          var info = data.info;
          var result = [];
      Severity: Minor
      Found in rdoc/js/searcher.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              case 40: //Event.KEY_DOWN:
                if (e.keyCode == 40 || e.ctrlKey) {
                  if (this.moveDown()) e.preventDefault();
                  this.startMoveTimeout(true);
                }
        Severity: Major
        Found in rdoc/js/navigation.js and 1 other location - About 1 hr to fix
        rdoc/js/navigation.js on lines 46..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              case 38: //Event.KEY_UP:
                if (e.keyCode == 38 || e.ctrlKey) {
                  if (this.moveUp()) e.preventDefault();
                  this.startMoveTimeout(false);
                }
        Severity: Major
        Found in rdoc/js/navigation.js and 1 other location - About 1 hr to fix
        rdoc/js/navigation.js on lines 55..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function onkeydown has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          this.onkeydown = function(e) {
            if (!this.navigationActive) return;
            switch(e.keyCode) {
              case 37: //Event.KEY_LEFT:
                if (this.moveLeft()) e.preventDefault();
        Severity: Minor
        Found in rdoc/js/navigation.js - About 1 hr to fix

          Function performSearch has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            function performSearch(data, regexps, queries, highlighters, state) {
          Severity: Minor
          Found in rdoc/js/searcher.js - About 35 mins to fix

            Function hookSearch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function hookSearch() {
              var input  = $('#search-field').eq(0);
              var result = $('#search-results').eq(0);
              $(result).show();
            
            
            Severity: Minor
            Found in rdoc/js/darkfish.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method opinio has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def opinio(options = {})
                  null    = options[:null] || false
                  default = options.key?(:default) ? options[:default] : ("" if null == false)
            
                  apply_opinio_schema :owner_id, :integer, :null => false
            Severity: Minor
            Found in lib/opinio/schema.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language