Sign upLogin

Drowze/aspirebudgeting_ruby

View on GitHub
Star

Showing 5 of 5 total issues

Method save has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

      def save # rubocop:disable all
        sent = false

        if @meta_modified
          add_request({
Severity: Minor
Found in lib/aspire_budget/core_extensions.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method save has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def save # rubocop:disable all
        sent = false

        if @meta_modified
          add_request({
Severity: Minor
Found in lib/aspire_budget/core_extensions.rb - About 1 hr to fix

    Method []= has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def []=(*args) # rubocop:disable all
        (row, col) = parse_cell_args(args[0...-1])
        value = args[-1]

        reload_cells unless @cells
    Severity: Minor
    Found in lib/aspire_budget/core_extensions.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method to_row has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def to_row(header)
        header.map do |h|
          value = send(h)
          next Utils.serialize_date(value) if h == :date
          next Utils.serialize_status(value) if h == :status
    Severity: Minor
    Found in lib/aspire_budget/models/transaction.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method serialize_date has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def serialize_date(value)
        return Float(value) if value.is_a?(Numeric) && value >= 0

        value = value.to_date if value.respond_to?(:to_date)
        raise 'Unsupported date value' unless value.is_a?(Date)
    Severity: Minor
    Found in lib/aspire_budget/utils.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language