Dynamoid/dynamoid

View on GitHub

Showing 39 of 60 total issues

File aws_sdk_v3.rb has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative 'aws_sdk_v3/query'
require_relative 'aws_sdk_v3/scan'
require_relative 'aws_sdk_v3/create_table'
require_relative 'aws_sdk_v3/batch_get_item'
require_relative 'aws_sdk_v3/item_updater'
Severity: Minor
Found in lib/dynamoid/adapter_plugin/aws_sdk_v3.rb - About 4 hrs to fix

    Class Chain has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Chain
          attr_reader :query, :source, :consistent_read, :key_fields_detector
    
          include Enumerable
          # Create a new criteria chain.
    Severity: Minor
    Found in lib/dynamoid/criteria/chain.rb - About 3 hrs to fix

      Class AwsSdkV3 has 28 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class AwsSdkV3
            EQ = 'EQ'
            RANGE_MAP = {
              range_greater_than: 'GT',
              range_less_than:    'LT',
      Severity: Minor
      Found in lib/dynamoid/adapter_plugin/aws_sdk_v3.rb - About 3 hrs to fix

        File chain.rb has 291 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require_relative 'key_fields_detector'
        require_relative 'ignored_conditions_detector'
        require_relative 'overwritten_conditions_detector'
        require_relative 'nonexistent_fields_detector'
        
        
        Severity: Minor
        Found in lib/dynamoid/criteria/chain.rb - About 3 hrs to fix

          Method _find_all has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

                def _find_all(ids, options = {})
                  if range_key
                    ids = ids.map do |pk, sk|
                      sk_casted = TypeCasting.cast_field(sk, attributes[range_key])
                      sk_dumped = Dumping.dump_field(sk_casted, attributes[range_key])
          Severity: Minor
          Found in lib/dynamoid/finders.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method dynamodb_type has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              def self.dynamodb_type(type, options)
                if type.is_a?(Class)
                  type = type.respond_to?(:dynamoid_field_type) ? type.dynamoid_field_type : :string
                end
          
          
          Severity: Minor
          Found in lib/dynamoid/primary_key_type_mapping.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method call has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def call
                    billing_mode = options[:billing_mode]
                    read_capacity = options[:read_capacity] || Dynamoid::Config.read_capacity
                    write_capacity = options[:write_capacity] || Dynamoid::Config.write_capacity
          
          
          Severity: Major
          Found in lib/dynamoid/adapter_plugin/aws_sdk_v3/create_table.rb - About 2 hrs to fix

            Method call has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                    def call
                      results = {}
            
                      tables_with_ids.each do |table, ids|
                        if ids.blank?
            Severity: Minor
            Found in lib/dynamoid/adapter_plugin/aws_sdk_v3/batch_get_item.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method call has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                    def call
                      billing_mode = options[:billing_mode]
                      read_capacity = options[:read_capacity] || Dynamoid::Config.read_capacity
                      write_capacity = options[:write_capacity] || Dynamoid::Config.write_capacity
            
            
            Severity: Minor
            Found in lib/dynamoid/adapter_plugin/aws_sdk_v3/create_table.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method _find_all has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def _find_all(ids, options = {})
                    if range_key
                      ids = ids.map do |pk, sk|
                        sk_casted = TypeCasting.cast_field(sk, attributes[range_key])
                        sk_dumped = Dumping.dump_field(sk_casted, attributes[range_key])
            Severity: Minor
            Found in lib/dynamoid/finders.rb - About 1 hr to fix

              Method update! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  def update!(conditions = {})
                    run_callbacks(:update) do
                      options = range_key ? { range_key: Dumping.dump_field(read_attribute(range_key), self.class.attributes[range_key]) } : {}
              
                      begin
              Severity: Minor
              Found in lib/dynamoid/persistence.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method field_hash has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def field_hash(key)
                      name, operation = key.to_s.split('.')
                      val = type_cast_condition_parameter(name, query[key])
              
                      hash = case operation
              Severity: Minor
              Found in lib/dynamoid/criteria/chain.rb - About 1 hr to fix

                Method find_all_by_secondary_index has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def find_all_by_secondary_index(hash, options = {})
                        ActiveSupport::Deprecation.warn('[Dynamoid] .find_all_by_secondary_index is deprecated! Call .where instead of')
                
                        range = options[:range] || {}
                        hash_key_field, hash_key_value = hash.first
                Severity: Minor
                Found in lib/dynamoid/finders.rb - About 1 hr to fix

                  Method delete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def delete
                        options = range_key ? { range_key: Dumping.dump_field(read_attribute(range_key), self.class.attributes[range_key]) } : {}
                  
                        # Add an optimistic locking check if the lock_version column exists
                        if self.class.attributes[:lock_version]
                  Severity: Minor
                  Found in lib/dynamoid/persistence.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method build_all_attribute_definitions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          def build_all_attribute_definitions(key_schema, secondary_indexes = {})
                            ls_indexes = secondary_indexes[:local_secondary_indexes]
                            gs_indexes = secondary_indexes[:global_secondary_indexes]
                  
                            attribute_definitions = []
                  Severity: Minor
                  Found in lib/dynamoid/adapter_plugin/aws_sdk_v3/create_table.rb - About 1 hr to fix

                    Method call has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def call
                              counter = 0
                              resp = nil
                              begin
                                check = { again: true }
                    Severity: Minor
                    Found in lib/dynamoid/adapter_plugin/aws_sdk_v3/until_past_table_status.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method call has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def call
                            @model.hash_key = SecureRandom.uuid if @model.hash_key.blank?
                    
                            # Add an optimistic locking check if the lock_version column exists
                            if @model.class.attributes[:lock_version]
                    Severity: Minor
                    Found in lib/dynamoid/persistence/save.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method sanitize_item has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def sanitize_item(attributes)
                            config_value = Dynamoid.config.store_attribute_with_nil_value
                            store_attribute_with_nil_value = config_value.nil? ? false : !!config_value
                    
                            attributes.reject do |_, v|
                    Severity: Minor
                    Found in lib/dynamoid/adapter_plugin/aws_sdk_v3.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def process(value)
                            if !value.respond_to?(:to_datetime)
                              nil
                            elsif value.is_a?(String)
                              dt = begin
                    Severity: Minor
                    Found in lib/dynamoid/type_casting.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method format_datetime has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def format_datetime(value, options)
                            use_string_format = if options[:store_as_string].nil?
                                                  Dynamoid.config.store_datetime_as_string
                                                else
                                                  options[:store_as_string]
                    Severity: Minor
                    Found in lib/dynamoid/dumping.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language