Sign upLogin

EVE-Tools/node-43

View on GitHub
Star

Showing 40 of 40 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  params = '($'+(count++)+
           '::float8, $'+(count++)+
           '::float8, $'+(count++)+
           '::float8, $'+(count++)+
           '::float8, $'+(count++)+
Severity: Major
Found in lib/messagePipeline/orderRegionStatsHistory.js and 1 other location - About 6 hrs to fix
lib/messagePipeline/orderRegionStats.js on lines 14..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  params = '($'+(count++)+
           '::float8, $'+(count++)+
           '::float8, $'+(count++)+
           '::float8, $'+(count++)+
           '::float8, $'+(count++)+
Severity: Major
Found in lib/messagePipeline/orderRegionStats.js and 1 other location - About 6 hrs to fix
lib/messagePipeline/orderRegionStatsHistory.js on lines 14..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      pgClient.query('INSERT INTO market_data_itemregionstat AS stats (buymean, ' +
        'buyavg, ' +
        'buymedian, ' +
        'sellmean, ' +
        'sellavg, ' +
Severity: Major
Found in lib/messagePipeline/orderRegionStats.js and 1 other location - About 4 hrs to fix
lib/messagePipeline/orderRegionStatsHistory.js on lines 75..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      pgClient.query('INSERT INTO market_data_itemregionstathistory AS stats (buymean, ' +
                      'buyavg, ' +
                      'buymedian, ' +
                      'sellmean, ' +
                      'sellavg, ' +
Severity: Major
Found in lib/messagePipeline/orderRegionStatsHistory.js and 1 other location - About 4 hrs to fix
lib/messagePipeline/orderRegionStats.js on lines 73..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (data[counter].is_bid === true) {

      // Process bids
      if (data[counter].price >= metrics.bidPercentile5 && data[counter].price <= metrics.bidPercentile95) {
        metrics.bidPricesSum += data[counter].price * data[counter].volume_remaining;
Severity: Major
Found in lib/messagePipeline/orderCalculateRegionStats.js and 1 other location - About 3 hrs to fix
lib/messagePipeline/orderCalculateRegionStats.js on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    } else {

      // Process asks
      if (data[counter].price >= metrics.askPercentile5 && data[counter].price <= metrics.askPercentile95) {
        metrics.askPricesSum = data[counter].price * data[counter].volume_remaining;
Severity: Major
Found in lib/messagePipeline/orderCalculateRegionStats.js and 1 other location - About 3 hrs to fix
lib/messagePipeline/orderCalculateRegionStats.js on lines 70..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

exports = module.exports = function(resultSet, callback) {
  //
  // Stores order statistics in itemRegionStats table
  //
Severity: Major
Found in lib/messagePipeline/orderRegionStats.js and 1 other location - About 2 hrs to fix
lib/messagePipeline/orderRegionStatsHistory.js on lines 119..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

exports = module.exports = function(resultSet, callback) {
  //
  // Stores order statistics in itemRegionStatsHistory table
  //
Severity: Major
Found in lib/messagePipeline/orderRegionStatsHistory.js and 1 other location - About 2 hrs to fix
lib/messagePipeline/orderRegionStats.js on lines 118..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      for (var i = 0; i < historyData.columns.length; i++) {
        historyObject[historyData.columns[i]] = historyData.rowsets[rowset].rows[row][i];
      }
Severity: Major
Found in lib/emds.js and 1 other location - About 1 hr to fix
lib/emds.js on lines 17..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      for (var i = 0; i < marketData.columns.length; i++) {
        orderObject[marketData.columns[i]] = marketData.rowsets[rowset].rows[row][i];
      }
Severity: Major
Found in lib/emds.js and 1 other location - About 1 hr to fix
lib/emds.js on lines 55..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function prepareQueryValues has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function prepareQueryValues(resultSet) {
  //
  // Prepare parametrized query
  //
Severity: Minor
Found in lib/messagePipeline/orderStore.js - About 1 hr to fix

    Function upsertRegionStats has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function upsertRegionStats(resultSet, callback) {

  var queryValues = prepareQueryValues(resultSet);

  // Get connection from pool
    Severity: Minor
    Found in lib/messagePipeline/orderRegionStats.js - About 1 hr to fix

      Function upsertRegionStatHistory has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function upsertRegionStatHistory(resultSet, callback) {

  var queryValues = prepareQueryValues(resultSet);

  // Get connection from pool
      Severity: Minor
      Found in lib/messagePipeline/orderRegionStatsHistory.js - About 1 hr to fix

        Function handleResponse has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        function handleResponse(task, callback, error, response, body) {
  //
  // Parse response, filter and store it
  //
        Severity: Minor
        Found in lib/crestPipeline/crestHistoryAgent.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prepareQueryValues has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function prepareQueryValues(resultSet) {
  //
  // Prepare parametrized query for history upsert
  //
        Severity: Minor
        Found in lib/messagePipeline/orderRegionStatsHistory.js - About 1 hr to fix

          Function getOrderObjects has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function getOrderObjects(marketData) {
  //
  // Takes parsed UUDIF messages and converts them into sanitized JS objects
  //
          Severity: Minor
          Found in lib/emds.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleResponse has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function handleResponse(task, callback, error, response, body) {
  //
  // Parse response, filter and store it
  //
          Severity: Minor
          Found in lib/crestPipeline/crestHistoryAgent.js - About 1 hr to fix

            Function prepareQueryValues has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function prepareQueryValues(resultSet) {
  //
  // Prepare parametrized query
  //
            Severity: Minor
            Found in lib/messagePipeline/orderRegionStats.js - About 1 hr to fix

              Function getStatisticalInformation has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function getStatisticalInformation(regionID, typeID, callback) {
  //
  // Return statistical properties of given region/type pair
  //
              Severity: Minor
              Found in lib/messagePipeline/orderProcessor.js - About 1 hr to fix

                Function exports has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                exports = module.exports = function(resultSet, callback) {
  //
  // Reduces dataset to neccessary datapoints missing in DB
  //
                Severity: Minor
                Found in lib/crestPipeline/crestHistoryDBFilter.js - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language