Sign upLogin

EmicoEcommerce/Magento2Tweakwise

View on GitHub
Star
Model/Catalog/Layer/ItemCollectionProvider.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function getCollection has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function getCollection(Category $category)
    {
        if (!$this->config->isLayeredEnabled()) {
            if (!$this->config->isSearchEnabled() || !($this->navigationContext->getRequest() instanceof ProductSearchRequest)) {
                return $this->originalProvider->getCollection($category);
Severity: Minor
Found in Model/Catalog/Layer/ItemCollectionProvider.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Config $config,
        Logger $log,
        ItemCollectionProviderInterface $originalProvider,
        CollectionFactory $collectionFactory,
        NavigationContext $navigationContext
Severity: Minor
Found in Model/Catalog/Layer/ItemCollectionProvider.php - About 35 mins to fix

    Avoid too many return statements within this method.
    Open

                return $this->originalProvider->getCollection($category);
    Severity: Major
    Found in Model/Catalog/Layer/ItemCollectionProvider.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status