EmicoEcommerce/Magento2Tweakwise

View on GitHub
Model/Client/Type/SuggestionType/SuggestionTypeFacet.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method getUrl has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getUrl(): string
    {
        $isSearch = false;
        try {
            $url = $this->getCategoryUrl();
Severity: Minor
Found in Model/Client/Type/SuggestionType/SuggestionTypeFacet.php - About 1 hr to fix

    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            UrlStrategyFactory $urlStrategyFactory,
            UrlInterface $url,
            CategoryRepository $categoryRepository,
            StoreManagerInterface $storeManager,
            Helper $exportHelper,
    Severity: Major
    Found in Model/Client/Type/SuggestionType/SuggestionTypeFacet.php - About 50 mins to fix

      Function getUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getUrl(): string
          {
              $isSearch = false;
              try {
                  $url = $this->getCategoryUrl();
      Severity: Minor
      Found in Model/Client/Type/SuggestionType/SuggestionTypeFacet.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status