Sign upLogin

EmicoEcommerce/Magento2Tweakwise

View on GitHub
Star
Model/Config.php

Summary

Maintainability
C
1 day
Test Coverage

Config has 45 functions (exceeds 20 allowed). Consider refactoring.
Open

class Config
{
    /**
     * Recommendation types
     */
Severity: Minor
Found in Model/Config.php - About 6 hrs to fix

    File Config.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Tweakwise (https://www.tweakwise.com/) - All Rights Reserved
 *
 * @copyright Copyright (c) 2017-2022 Tweakwise.com B.V. (https://www.tweakwise.com)
    Severity: Minor
    Found in Model/Config.php - About 3 hrs to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(ScopeConfigInterface $config, Json $jsonSerializer, RequestInterface $request, State $state, WriterInterface $configWriter, TypeListInterface $cacheTypeList)
      Severity: Minor
      Found in Model/Config.php - About 45 mins to fix

        Avoid too many return statements within this method.
        Open

                    return;
        Severity: Major
        Found in Model/Config.php - About 30 mins to fix

          Function getStoreConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getStoreConfig(string $path, Store $store = null)
    {
        if ($store) {
            return $store->getConfig($path);
        }
          Severity: Minor
          Found in Model/Config.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public function __construct(ScopeConfigInterface $config, Json $jsonSerializer, RequestInterface $request, State $state, WriterInterface $configWriter, TypeListInterface $cacheTypeList)
    {
        $this->config = $config;
        $this->jsonSerializer = $jsonSerializer;
        $this->request = $request;
          Severity: Major
          Found in Model/Config.php and 2 other locations - About 1 hr to fix
          Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php on lines 106..120
          Model/Catalog/Product/Recommendation/Context.php on lines 76..90

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status