Sign upLogin

EmicoEcommerce/Magento2Tweakwise

View on GitHub
Star
Model/Config/TemplateFinder.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method forProduct has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function forProduct(Product $product, $type)
    {
        $attribute = $this->getAttribute($type);
        $templateId = (int) $product->getData($attribute);
Severity: Minor
Found in Model/Config/TemplateFinder.php - About 1 hr to fix

    Function forProduct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function forProduct(Product $product, $type)
    {
        $attribute = $this->getAttribute($type);
        $templateId = (int) $product->getData($attribute);
    Severity: Minor
    Found in Model/Config/TemplateFinder.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $defaultTemplateId;
    Severity: Major
    Found in Model/Config/TemplateFinder.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $templateId;
      Severity: Major
      Found in Model/Config/TemplateFinder.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $this->config->getRecommendationsGroupCode($type);
        Severity: Major
        Found in Model/Config/TemplateFinder.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status