EmicoEcommerce/Magento2Tweakwise

View on GitHub

Showing 120 of 157 total issues

Config has 45 functions (exceeds 20 allowed). Consider refactoring.
Open

class Config
{
    /**
     * Recommendation types
     */
Severity: Minor
Found in Model/Config.php - About 6 hrs to fix

    Function getSwatchData has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getSwatchData()
        {
            if (false === $this->eavAttribute instanceof Attribute) {
                throw new \RuntimeException('Magento_Swatches: RenderLayered: Attribute has not been set.');
            }
    Severity: Minor
    Found in Block/LayeredNavigation/RenderLayered/SwatchRenderer.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File QueryParameterStrategy.php has 365 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * Tweakwise (https://www.tweakwise.com/) - All Rights Reserved
     *
     * @copyright Copyright (c) 2017-2022 Tweakwise.com B.V. (https://www.tweakwise.com)
    Severity: Minor
    Found in Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php - About 4 hrs to fix

      Filter has 36 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Filter extends AbstractFilter implements FilterInterface
      {
          /**
           * @var string
           */
      Severity: Minor
      Found in Model/Catalog/Layer/Filter.php - About 4 hrs to fix

        File PathSlugStrategy.php has 348 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /**
         * Tweakwise (https://www.tweakwise.com/) - All Rights Reserved
         *
         * @copyright Copyright (c) 2017-2022 Tweakwise.com B.V. (https://www.tweakwise.com)
        Severity: Minor
        Found in Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php - About 4 hrs to fix

          File Config.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          /**
           * Tweakwise (https://www.tweakwise.com/) - All Rights Reserved
           *
           * @copyright Copyright (c) 2017-2022 Tweakwise.com B.V. (https://www.tweakwise.com)
          Severity: Minor
          Found in Model/Config.php - About 3 hrs to fix

            Function getShoppingcartCrosssellItems has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getShoppingcartCrosssellItems(array $cartProductIds, array $result)
                {
                    $items = [];
            
                    if ($cartProductIds) {
            Severity: Minor
            Found in Block/Checkout/Cart/Crosssell/Plugin.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getShoppingcartCrosssellItems has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getShoppingcartCrosssellItems(array $cartProductIds, array $result)
                {
                    $items = [];
            
                    if ($cartProductIds) {
            Severity: Minor
            Found in Block/Cart/Crosssell/Plugin.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 21 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    CollectionEntityFactory $entityFactory,
                    LoggerInterface $logger,
                    FetchStrategyInterface $fetchStrategy,
                    ManagerInterface $eventManager,
                    EavConfig $eavConfig,
            Severity: Major
            Found in Model/Catalog/Product/Recommendation/Collection.php - About 2 hrs to fix

              Method __construct has 21 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      CollectionEntityFactory $entityFactory,
                      LoggerInterface $logger,
                      FetchStrategyInterface $fetchStrategy,
                      ManagerInterface $eventManager,
                      EavConfig $eavConfig,
              Severity: Major
              Found in Model/Catalog/Product/Collection.php - About 2 hrs to fix

                File Filter.php has 272 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                /**
                 * Tweakwise (https://www.tweakwise.com/) - All Rights Reserved
                 *
                 * @copyright Copyright (c) 2017-2022 Tweakwise.com B.V. (https://www.tweakwise.com)
                Severity: Minor
                Found in Model/Catalog/Layer/Filter.php - About 2 hrs to fix

                  File navigation-form.js has 269 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /**
                   * Tweakwise (https://www.tweakwise.com/) - All Rights Reserved
                   *
                   * @copyright Copyright (c) 2017-2022 Tweakwise.com B.V. (https://www.tweakwise.com)
                   * @license   http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
                  Severity: Minor
                  Found in view/frontend/web/js/navigation-form.js - About 2 hrs to fix

                    Function _updateBlocks has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            _updateBlocks: function (htmlResponse) {
                                var filterSelector = this.options.filterSelector;
                                var productListSelector = this.options.productListSelector;
                                var toolbarSelector = this.options.toolbarSelector;
                    
                    
                    Severity: Major
                    Found in view/frontend/web/js/navigation-form.js - About 2 hrs to fix

                      Method getSwatchData has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function getSwatchData()
                          {
                              if (false === $this->eavAttribute instanceof Attribute) {
                                  throw new \RuntimeException('Magento_Swatches: RenderLayered: Attribute has not been set.');
                              }
                      Severity: Major
                      Found in Block/LayeredNavigation/RenderLayered/SwatchRenderer.php - About 2 hrs to fix

                        Function execute has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function execute()
                            {
                                $json = $this->resultFactory->create('json');
                                $facetRequest = $this->requestFactory->create();
                        
                        
                        Severity: Minor
                        Found in Controller/Ajax/FacetAttributes.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function apply has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function apply(MagentoHttpRequest $request, ProductNavigationRequest $navigationRequest): FilterApplierInterface
                            {
                                $attributeFilters = $this->getAttributeFilters($request);
                                foreach ($attributeFilters as $attribute => $values) {
                                    if (!is_array($values)) {
                        Severity: Minor
                        Found in Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method __construct has 16 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                ConfigInterface $routeConfig,
                                RequestInterface $request,
                                SecurityInfoInterface $urlSecurityInfo,
                                ScopeResolverInterface $scopeResolver,
                                Generic $session,
                        Severity: Major
                        Found in Model/Catalog/Layer/Url/UrlModel.php - About 2 hrs to fix

                          Method apply has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function apply(MagentoHttpRequest $request, ProductNavigationRequest $navigationRequest): FilterApplierInterface
                              {
                                  $attributeFilters = $this->getAttributeFilters($request);
                                  foreach ($attributeFilters as $attribute => $values) {
                                      if (!is_array($values)) {
                          Severity: Minor
                          Found in Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php - About 1 hr to fix

                            Method getItems has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function getItems()
                                {
                                    $query = $this->dataProviderHelper->getQuery();
                                    $category = $this->dataProviderHelper->getCategory();
                                    $promises = [];
                            Severity: Minor
                            Found in Model/Autocomplete/DataProvider/SuggestionDataProvider.php - About 1 hr to fix

                              Method match has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function match(MagentoHttpRequest $request)
                                  {
                                      if ($this->skip($request)) {
                                          return false;
                                      }
                              Severity: Minor
                              Found in Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language