EmicoEcommerce/Magento2Tweakwise

View on GitHub

Showing 121 of 156 total issues

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

        View\Element\Template\Context $context,
        View\LayoutFactory $layoutFactory,
        View\Layout\ReaderPool $layoutReaderPool,
        Framework\Translate\InlineInterface $translateInline,
        View\Layout\BuilderFactory $layoutBuilderFactory,
Severity: Major
Found in Model/AjaxNavigationResult.php - About 1 hr to fix

    Method execute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute()
        {
            $json = $this->resultFactory->create('json');
            $facetRequest = $this->requestFactory->create();
    
    
    Severity: Minor
    Found in Controller/Ajax/FacetAttributes.php - About 1 hr to fix

      Method apply has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function apply()
          {
              $eavSetup = $this->eavSetupFactory->create(['setup' => $this->moduleDataSetup]);
      
              $eavSetup->addAttribute(
      Severity: Minor
      Found in Setup/Patch/Data/AddFilterAndFilterValuesCategoryAttribute.php - About 1 hr to fix

        Method handleRequestSuccess has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function handleRequestSuccess(
                ResponseInterface $httpResponse,
                HttpRequest $httpRequest,
                Request $tweakwiseRequest,
            ): Response {
        Severity: Minor
        Found in Model/Client.php - About 1 hr to fix

          Method initFilters has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function initFilters(Layer $layer)
              {
                  $request = $this->context->getRequest();
                  if (!$request->hasParameter('tn_cid')) {
                      $request->addCategoryFilter($layer->getCurrentCategory());
          Severity: Minor
          Found in Model/Catalog/Layer/FilterList/Tweakwise.php - About 1 hr to fix

            Method forProduct has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function forProduct(Product $product, $type)
                {
                    $attribute = $this->getAttribute($type);
                    $templateId = (int) $product->getData($attribute);
            
            
            Severity: Minor
            Found in Model/Config/TemplateFinder.php - About 1 hr to fix

              Function getSearchBanners has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function getSearchBanners()
                  {
                      $navigationContext = $this->getData('tweakwise_navigation_context')->getNavigationContext()->getContext();
                      $result = [];
                      $banners = [];
              Severity: Minor
              Found in Block/Navigation/SearchBanner/SearchBannerRenderer.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function prepareFieldsMeta has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function prepareFieldsMeta($fieldsMap, $fieldsMeta)
                  {
                      $canEditDesign = $this->auth->isAllowed('Magento_Catalog::edit_category_design');
              
                      $result = [];
              Severity: Minor
              Found in Model/Category/DataProvider/Plugin.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method install has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function install(SchemaSetupInterface $setup, ModuleContextInterface $context)
                  {
                      $installer = $setup;
                      $installer->startSetup();
              
              
              Severity: Minor
              Found in Setup/InstallSchema.php - About 1 hr to fix

                Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        UrlModel $magentoUrl,
                        UrlFactory $urlFactory,
                        Resolver $layerResolver,
                        FilterSlugManager $filterSlugManager,
                        QueryParameterStrategy $queryParameterStrategy,
                Severity: Major
                Found in Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php - About 1 hr to fix

                  Method getUrl has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getUrl(): string
                      {
                          $isSearch = false;
                          try {
                              $url = $this->getCategoryUrl();
                  Severity: Minor
                  Found in Model/Client/Type/SuggestionType/SuggestionTypeFacet.php - About 1 hr to fix

                    Method getOriginalUrl has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getOriginalUrl(MagentoHttpRequest $request): string
                        {
                            if ($twOriginalUrl = $request->getParam('__tw_original_url')) {
                                // This seems ugly, perhaps there is another way?
                                $query = [];
                    Severity: Minor
                    Found in Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php - About 1 hr to fix

                      Method getSwatchData has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function getSwatchData(Filter $filter): array
                          {
                              // Get a map of filter item labels keyed by label
                              $labels = array_flip(
                                  array_map(
                      Severity: Minor
                      Found in Model/Swatches/SwatchAttributeResolver.php - About 1 hr to fix

                        Method getCategoryFilterSelectUrl has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getCategoryFilterSelectUrl(MagentoHttpRequest $request, Item $item): string
                            {
                                $category = $this->strategyHelper->getCategoryFromItem($item);
                                if (!$this->getSearch($request)) {
                                    $categoryUrl = $category->getUrl();
                        Severity: Minor
                        Found in Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php - About 1 hr to fix

                          Method execute has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function execute(Observer $observer)
                              {
                                  if (!$this->config->isSearchEnabled()) {
                                      return;
                                  }
                          Severity: Minor
                          Found in Model/Observer/CatalogSearchRedirect.php - About 1 hr to fix

                            Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    Config $config,
                                    RequestFactory $requestFactory,
                                    Client $client,
                                    Url $url,
                                    FilterableAttributeListInterface $filterableAttributes,
                            Severity: Major
                            Found in Model/Catalog/Layer/NavigationContext.php - About 1 hr to fix

                              Function getOriginalUrl has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function getOriginalUrl(MagentoHttpRequest $request): string
                                  {
                                      if ($twOriginalUrl = $request->getParam('__tw_original_url')) {
                                          // This seems ugly, perhaps there is another way?
                                          $query = [];
                              Severity: Minor
                              Found in Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      ProductContext $productContext,
                                      PostHelper $postDataHelper,
                                      Resolver $layerResolver,
                                      TemplateFinder $templateFinder,
                                      CategoryRepositoryInterface $categoryRepository,
                              Severity: Major
                              Found in Block/Catalog/Product/ProductList/Featured.php - About 1 hr to fix

                                Function forProduct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function forProduct(Product $product, $type)
                                    {
                                        $attribute = $this->getAttribute($type);
                                        $templateId = (int) $product->getData($attribute);
                                
                                
                                Severity: Minor
                                Found in Model/Config/TemplateFinder.php - About 1 hr to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function getOriginalUrl has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function getOriginalUrl(MagentoHttpRequest $request) : string
                                    {
                                        if ($originalUrl = $request->getQuery('__tw_original_url')) {
                                            $urlArray = explode('/', $originalUrl);
                                            $newOriginalUrl = '';
                                Severity: Minor
                                Found in Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php - About 1 hr to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language