EmicoEcommerce/Magento2Tweakwise

View on GitHub

Showing 120 of 157 total issues

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        TranslitUrl $translitUrl,
        AttributeSlugRepositoryInterface $attributeSlugRepository,
        AttributeSlugInterfaceFactory $attributeSlugFactory,
        CacheInterface $cache,
        SerializerInterface $serializer
Severity: Minor
Found in Model/Catalog/Layer/Url/Strategy/FilterSlugManager.php - About 35 mins to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            UrlStrategyFactory $urlStrategyFactory,
            MagentoHttpRequest $request,
            CategoryRepositoryInterface $categoryRepository,
            ExportHelper $exportHelper,
            UrlModel $magentoUrl
    Severity: Minor
    Found in Model/Catalog/Layer/Url.php - About 35 mins to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Layer $layer,
              FacetType $facet,
              ItemFactory $itemFactory,
              StoreManager $storeManager,
              Attribute $attribute = null
      Severity: Minor
      Found in Model/Catalog/Layer/Filter.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct(Config $config, LocaleFormat $localeFormat, Registry $registry, Context $context, array $data = [])
        Severity: Minor
        Found in Block/Autocomplete/FormMini.php - About 35 mins to fix

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  AttributeSlugResource $resource,
                  AttributeSlugInterfaceFactory $entityFactory,
                  CollectionFactory $collectionFactory,
                  AttributeSlugSearchResultsInterfaceFactory $searchResultsFactory,
                  CollectionProcessorInterface $collectionProcessor
          Severity: Minor
          Found in Model/AttributeSlugRepository.php - About 35 mins to fix

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    Config $config,
                    Logger $log,
                    ResponseFactory $responseFactory,
                    EndpointManager $endpointManager,
                    Timer $timer
            Severity: Minor
            Found in Model/Client.php - About 35 mins to fix

              Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      Config $config,
                      Logger $log,
                      ItemCollectionProviderInterface $originalProvider,
                      CollectionFactory $collectionFactory,
                      NavigationContext $navigationContext
              Severity: Minor
              Found in Model/Catalog/Layer/ItemCollectionProvider.php - About 35 mins to fix

                Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function execute(Observer $observer)
                    {
                        $block = $observer->getData('block');
                        if (!$block instanceof Navigation) {
                            return;
                Severity: Minor
                Found in Model/Observer/NavigationHtmlOverride.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function execute(Observer $observer)
                    {
                        foreach ($observer->getEvent()->getAttribute()->getOptions() as $option) {
                            try {
                                if (empty($option->getLabel()) || ctype_space((string) $option->getLabel())) {
                Severity: Minor
                Found in Observer/RemoveTweakwiseSlugsBeforeSaveAttribute.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function extractFilterValuesWhitelist has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function extractFilterValuesWhitelist(?string $filterList = null): array
                    {
                        if (empty($filterList)) {
                            return [];
                        }
                Severity: Minor
                Found in Model/ConfigAttributeProcessService.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function aroundLoadVariationByFallback has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function aroundLoadVariationByFallback(
                        Data $subject,
                        callable $proceed,
                        Product $parentProduct,
                        array $attributes
                Severity: Minor
                Found in Model/Swatches/Plugin.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function addCategoryFilter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function addCategoryFilter($category)
                    {
                        $ids = [];
                        if (is_numeric($category)) {
                            $ids[] = $category;
                Severity: Minor
                Found in Model/Client/Request.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getAttributeSelectUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getAttributeSelectUrl(MagentoHttpRequest $request, Item $item): string
                    {
                        $settings = $item
                            ->getFilter()
                            ->getFacet()
                Severity: Minor
                Found in Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getUrl(): string
                    {
                        $isSearch = false;
                        try {
                            $url = $this->getCategoryUrl();
                Severity: Minor
                Found in Model/Client/Type/SuggestionType/SuggestionTypeFacet.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function buildFilterUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function buildFilterUrl(MagentoHttpRequest $request, array $filters = []): string
                    {
                        $currentUrl = $this->getOriginalUrl($request);
                
                        $currentFilterPath = $request->getParam(self::REQUEST_FILTER_PATH);
                Severity: Minor
                Found in Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                        return true;
                Severity: Major
                Found in Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return;
                  Severity: Major
                  Found in Model/Observer/CatalogSearchRedirect.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return;
                    Severity: Major
                    Found in Model/Config.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return $proceed($layer);
                      Severity: Major
                      Found in Model/Catalog/Layer/FilterList/Plugin.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return $this->config->getRecommendationsGroupCode($type);
                        Severity: Major
                        Found in Model/Config/TemplateFinder.php - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language