EmicoEcommerce/Magento2Tweakwise

View on GitHub
view/frontend/web/js/navigation-form.js

Summary

Maintainability
C
1 day
Test Coverage

File navigation-form.js has 269 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Tweakwise (https://www.tweakwise.com/) - All Rights Reserved
 *
 * @copyright Copyright (c) 2017-2022 Tweakwise.com B.V. (https://www.tweakwise.com)
 * @license   http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
Severity: Minor
Found in view/frontend/web/js/navigation-form.js - About 2 hrs to fix

    Function _updateBlocks has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _updateBlocks: function (htmlResponse) {
                var filterSelector = this.options.filterSelector;
                var productListSelector = this.options.productListSelector;
                var toolbarSelector = this.options.toolbarSelector;
    
    
    Severity: Major
    Found in view/frontend/web/js/navigation-form.js - About 2 hrs to fix

      Function _ajaxHandler has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _ajaxHandler: function (event) {
                  event.preventDefault();
      
                  if (this.currentXhr) {
                      this.currentXhr.abort();
      Severity: Minor
      Found in view/frontend/web/js/navigation-form.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                _stopLoader: function () {
                    $(this.options.productListSelector).trigger('processStop');
                    this.options.isLoading = false;
                },
        Severity: Minor
        Found in view/frontend/web/js/navigation-form.js and 1 other location - About 45 mins to fix
        view/frontend/web/js/navigation-form.js on lines 444..447

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                _startLoader: function () {
                    $(this.options.productListSelector).trigger('processStart');
                    this.options.isLoading = true;
                },
        Severity: Minor
        Found in view/frontend/web/js/navigation-form.js and 1 other location - About 45 mins to fix
        view/frontend/web/js/navigation-form.js on lines 453..456

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    responseQueryString.forEach((value, key) => {
                        if (false === uniqueQueryParams.has(key)) {
                            uniqueQueryParams.append(key, value);
                        }
                    });
        Severity: Minor
        Found in view/frontend/web/js/navigation-form.js and 1 other location - About 40 mins to fix
        view/frontend/web/js/navigation-form.js on lines 425..429

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    origQueryString.forEach((value, key) => {
                        if (false === uniqueQueryParams.has(key)) {
                            uniqueQueryParams.append(key, value);
                        }
                    });
        Severity: Minor
        Found in view/frontend/web/js/navigation-form.js and 1 other location - About 40 mins to fix
        view/frontend/web/js/navigation-form.js on lines 431..435

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status