Sign upLogin

Enterprise-CMCS/macpro-mako

View on GitHub
Star

Showing 140 of 140 total issues

Function handler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

export const handler = async function (
  event: CloudFormationCustomResourceEvent,
) {
  console.log("Request:", JSON.stringify(event, undefined, 2));
  const resourceProperties = event.ResourceProperties;
Severity: Minor
Found in lib/local-constructs/create-topics/src/createTopics.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function looksLikeCsv has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

async function looksLikeCsv(
  filePath: string,
  delimiter: string = ",",
  maxLinesToCheck: number = 10,
): Promise<boolean> {
Severity: Minor
Found in lib/local-constructs/clamav-scanning/src/lib/file-ext.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

export const handler: Handler<KafkaEvent> = async (event) => {
  const requiredEnvVars = [
    "emailAddressLookupSecretName",
    "applicationEndpointUrl",
    "osDomain",
Severity: Minor
Found in lib/lambda/processEmails.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function RHFSlot has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

export const RHFSlot = <
  TFieldValues extends FieldValues = FieldValues,
  TName extends FieldPath<TFieldValues> = FieldPath<TFieldValues>,
>({
  control,
Severity: Minor
Found in react-app/src/components/RHF/Slot.tsx - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function initializeResources has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  private initializeResources(props: UiInfraStackProps): {
    distribution: cdk.aws_cloudfront.CloudFrontWebDistribution;
    bucket: cdk.aws_s3.Bucket;
  } {
    const { project, stage, isDev, domainCertificateArn, domainName } = props;
Severity: Minor
Found in lib/stacks/ui-infra.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function UserPrompt has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

export const UserPrompt = () => {
  const [activeUserPrompt, setActiveUserPrompt] = useState<UserPrompt | null>(
    null,
  );
  const [isOpen, setIsOpen] = useState<boolean>(false);
Severity: Minor
Found in react-app/src/components/ConfirmationDialog/userPrompt.tsx - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkIfAuthenticated has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

export async function checkIfAuthenticated(): Promise<void> {
  try {
    const client = new STSClient({ region });
    const command = new GetCallerIdentityCommand({});
    await client.send(command);
Severity: Minor
Found in bin/cli/src/lib/sts.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

  if (
    (rules?.maxLength || rules?.minLength) &&
    !isEmpty &&
    isString(inputValue)
  ) {
Severity: Major
Found in react-app/src/components/RHF/utils/validator.ts - About 40 mins to fix

    Consider simplifying this complex logical expression.
    Open

        if (checker.authorityIs([Authority["CHIP_SPA"]])) {
      return (
        !checker.isTempExtension &&
        checker.isNotWithdrawn &&
        checker.hasRaiResponse &&
    Severity: Major
    Found in lib/packages/shared-utils/package-actions/rules.ts - About 40 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      export const Waiver1915bCMSEmail = (props: {
  variables:
    | (Events["CapitatedInitial"] & CommonEmailVariables)
    | (Events["ContractingInitial"] & CommonEmailVariables);
}) => {
      Severity: Minor
      Found in lib/libs/email/content/new-submission/emailTemplates/Waiver1915bCMS.tsx and 1 other location - About 35 mins to fix
      lib/libs/email/content/new-submission/emailTemplates/Waiver1915bState.tsx on lines 14..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      export const Waiver1915bStateEmail = (props: {
  variables:
    | (Events["CapitatedInitial"] & CommonEmailVariables)
    | (Events["ContractingInitial"] & CommonEmailVariables);
}) => {
      Severity: Minor
      Found in lib/libs/email/content/new-submission/emailTemplates/Waiver1915bState.tsx and 1 other location - About 35 mins to fix
      lib/libs/email/content/new-submission/emailTemplates/Waiver1915bCMS.tsx on lines 12..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function DependencyWrapperHandler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      const DependencyWrapperHandler = ({
  name,
  dependency,
  children,
  parentValue,
      Severity: Minor
      Found in react-app/src/components/RHF/dependencyWrapper.tsx - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function uploadAVDefinitions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const uploadAVDefinitions = async (): Promise<void[]> => {
  // delete all the definitions currently in the bucket.
  // first list them.
  logger.info("Uploading Definitions");
  const s3AllFullKeys: string[] = await listBucketFiles(
      Severity: Minor
      Found in lib/local-constructs/clamav-scanning/src/lib/clamav.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function transform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const transform = (offset: number) => {
  return events["contracting-amendment"].schema.transform((data) => {
    const attachments = data.attachments
      ? Object.entries(data.attachments).flatMap(
          //eslint-disable-next-line
      Severity: Minor
      Found in lib/packages/shared-types/opensearch/changelog/transforms/contracting-amendment.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function transform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const transform = (id: string) => {
  return seatoolSchema.transform((data) => {
    const { leadAnalystName, leadAnalystOfficerId, leadAnalystEmail } = getLeadAnalyst(data);
    const { raiReceivedDate, raiRequestedDate, raiWithdrawnDate } = getRaiDate(data);
    const seatoolStatus = data.STATE_PLAN.SPW_STATUS_ID
      Severity: Minor
      Found in lib/packages/shared-types/opensearch/main/transforms/seatool.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function transform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const transform = (offset: number) => {
  return events["respond-to-rai"].schema.transform((data) => {
    const attachments = data.attachments
      ? Object.entries(data.attachments).flatMap(
          //eslint-disable-next-line
      Severity: Minor
      Found in lib/packages/shared-types/opensearch/changelog/transforms/respond-to-rai.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function transform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const transform = (offset: number) => {
  return events["capitated-renewal"].schema.transform((data) => {
    const attachments = data.attachments
      ? Object.entries(data.attachments).flatMap(
          //eslint-disable-next-line
      Severity: Minor
      Found in lib/packages/shared-types/opensearch/changelog/transforms/capitated-renewal.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Amendment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const Amendment = () => {
  const { id } = useParams();
  const { data: submission, isLoading: isSubmissionLoading } = useGetItem(id);

  if (submission == undefined && isSubmissionLoading === true) {
      Severity: Minor
      Found in react-app/src/features/forms/post-submission/amend/index.tsx - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function transform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const transform = (offset: number) => {
  return events["upload-subsequent-documents"].schema.transform((data) => {
    const attachments = data.attachments
      ? Object.entries(data.attachments).flatMap(([, attachment]) => {
          // Check if 'attachment' exists and has a non-empty 'files' array
      Severity: Minor
      Found in lib/packages/shared-types/opensearch/changelog/transforms/upload-subsequent-documents.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function transform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const transform = (offset: number) => {
  return events["contracting-initial"].schema.transform((data) => {
    const attachments = data.attachments
      ? Object.entries(data.attachments).flatMap(
          //eslint-disable-next-line
      Severity: Minor
      Found in lib/packages/shared-types/opensearch/changelog/transforms/contracting-initial.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language