src/Dto/ConsultationUserResourceDto.php
The class ConsultationUserResourceDto has 25 fields. Consider redesigning ConsultationUserResourceDto to keep the number of fields under 15. Open
Open
class ConsultationUserResourceDto extends BaseDto
{
public ?int $id = null;
public ?string $firstName = null;
public ?string $lastName = null;- Read upRead up
- Exclude checks
TooManyFields
Since: 0.1
Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.
Example
class Person {
protected $one;
private $two;
private $three;
[... many more fields ...]
}Source https://phpmd.org/rules/codesize.html#toomanyfields
syntax error, unexpected '?', expecting function (T_FUNCTION) or const (T_CONST) Open
Open
public ?int $id = null;- Exclude checks
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
public ?int $id = null;- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}