EscolaLMS/Consultations

View on GitHub
src/Repositories/Contracts/ConsultationUserTermRepositoryContract.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Return type of getAllUserTermsByConsultationIdAndExecutedAt() is undeclared type \Illuminate\Support\Collection
Open

    public function getAllUserTermsByConsultationIdAndExecutedAt(int $consultationId, string $executedAt): Collection;

Return type of getBusyTerms() is undeclared type \Illuminate\Support\Collection
Open

    public function getBusyTerms(int $consultationId, ?string $date = null): Collection;

Doc-block of getBusyTerms contains declared return type \Illuminate\Support\Collection<int></int> which is incompatible with the return type \Illuminate\Support\Collection declared in the signature
Open

     * @return Collection<int, Model>

Parameter $models has undeclared type \Illuminate\Support\Collection
Open

    public function updateModels(Collection $models, array $data): void;

Return type of allQueryBuilder() is undeclared type \Illuminate\Support\Collection
Open

    public function allQueryBuilder(?FilterConsultationTermsListDto $filterConsultationTermsListDto = null): Collection;

Return type of getByCurrentUserTutor() is undeclared type \Illuminate\Support\Collection
Open

    public function getByCurrentUserTutor(): Collection;

Parameter $filterConsultationTermsListDto has undeclared type ?\EscolaLms\Consultations\Dto\FilterConsultationTermsListDto
Open

    public function allQueryBuilder(?FilterConsultationTermsListDto $filterConsultationTermsListDto = null): Collection;

Class implements undeclared interface \EscolaLms\Core\Repositories\Contracts\BaseRepositoryContract
Open

interface ConsultationUserTermRepositoryContract extends BaseRepositoryContract

Return type of getBusyTerms() is undeclared type \Illuminate\Support\Collection<int></int>
Open

    public function getBusyTerms(int $consultationId, ?string $date = null): Collection;

Avoid excessively long variable names like $filterConsultationTermsListDto. Keep variable name length under 20.
Open

    public function allQueryBuilder(?FilterConsultationTermsListDto $filterConsultationTermsListDto = null): Collection;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationUserPivot. Keep variable name length under 20.
Open

    public function updateUserTermByExecutedAt(ConsultationUserPivot $consultationUserPivot, string $executedAt, array $data): ConsultationUserTerm;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationUserPivot. Keep variable name length under 20.
Open

    public function createUserTerm(ConsultationUserPivot $consultationUserPivot, array $data): ConsultationUserTerm;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The closing brace for the interface must go on the next line after the body
Open

}

Line exceeds 120 characters; contains 140 characters
Open

    public function updateByConsultationUserIdAndExecutedAt(int $consultationUserId, string $executedAt, array $data): ConsultationUserTerm;

Line exceeds 120 characters; contains 148 characters
Open

    public function updateUserTermByExecutedAt(ConsultationUserPivot $consultationUserPivot, string $executedAt, array $data): ConsultationUserTerm;

There are no issues that match your filters.

Category
Status